fix(sandbox): add remove_dir permissions to sandbox #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
extend-landlock-perms
branch
from
001ee75 to
8801654
Compare
When an extraction directory is empty, unblob will try to delete it. This can lead to PermissionError due to insufficient permissions within the sandbox. The same can happen when deleting files. We therefore allow unblob to delete directories and files from the extraction directory with the remove_dir and remove_file permissions.
qkaiser
force-pushed
the
extend-landlock-perms
branch
from
8801654 to
ac9cf6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an extraction directory is empty, unblob will try to delete it.
This can lead to PermissionError due to insufficient permissions within the sandbox.
this needs to land in unblob-native first: onekey-sec/unblob-native#82