Skip to content

Commit

Permalink
Temporarily remove 3rd party rules and customize antfu defaults (#48)
Browse files Browse the repository at this point in the history
  • Loading branch information
joegeary authored Dec 3, 2024
1 parent 1d64112 commit 40cdeec
Show file tree
Hide file tree
Showing 17 changed files with 390 additions and 477 deletions.
4 changes: 2 additions & 2 deletions .github/renovate.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>oncoursesystems/renovate-config"]
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>oncoursesystems/renovate-config"]
}
92 changes: 46 additions & 46 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,53 +1,53 @@
{

// Auto fix
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit",
"source.organizeImports": "never"
},
"editor.formatOnSave": false,
// Auto fix
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit",
"source.organizeImports": "never"
},
"editor.formatOnSave": false,

"eslint.options": {
"flags": ["unstable_ts_config"]
},
"eslint.options": {
"flags": ["unstable_ts_config"]
},

// Silent the stylistic rules in you IDE, but still auto fix them
"eslint.rules.customizations": [
{ "fixable": true, "rule": "style/*", "severity": "off" },
{ "fixable": true, "rule": "*-indent", "severity": "off" },
{ "fixable": true, "rule": "*-spacing", "severity": "off" },
{ "fixable": true, "rule": "*-spaces", "severity": "off" },
{ "fixable": true, "rule": "*-order", "severity": "off" },
{ "fixable": true, "rule": "*-dangle", "severity": "off" },
{ "fixable": true, "rule": "*-newline", "severity": "off" },
{ "fixable": true, "rule": "*quotes", "severity": "off" },
{ "fixable": true, "rule": "*semi", "severity": "off" }
],
"eslint.runtime": "node",
// Silent the stylistic rules in you IDE, but still auto fix them
"eslint.rules.customizations": [
{ "fixable": true, "rule": "style/*", "severity": "off" },
{ "fixable": true, "rule": "*-indent", "severity": "off" },
{ "fixable": true, "rule": "*-spacing", "severity": "off" },
{ "fixable": true, "rule": "*-spaces", "severity": "off" },
{ "fixable": true, "rule": "*-order", "severity": "off" },
{ "fixable": true, "rule": "*-dangle", "severity": "off" },
{ "fixable": true, "rule": "*-newline", "severity": "off" },
{ "fixable": true, "rule": "*quotes", "severity": "off" },
{ "fixable": true, "rule": "*semi", "severity": "off" }
],
"eslint.runtime": "node",

// Enable eslint for all supported languages
"eslint.validate": [
"html",
"javascript",
"javascriptreact",
"json",
"json5",
"jsonc",
"markdown",
"toml",
"typescript",
"typescriptreact",
"vue",
"xml",
"yaml"
],
// Enable eslint for all supported languages
"eslint.validate": [
"html",
"javascript",
"javascriptreact",
"json",
"json5",
"jsonc",
"markdown",
"toml",
"typescript",
"typescriptreact",
"vue",
"xml",
"yaml"
],

"pair-diff.patterns": [
{
"source": "./fixtures/output/**/*.*",
"target": "./fixtures/input/<base>"
}
],
// Disable the default formatter, use eslint instead
"prettier.enable": false
"pair-diff.patterns": [
{
"source": "./fixtures/output/**/*.*",
"target": "./fixtures/input/<base>"
}
],
// Disable the default formatter, use eslint instead
"prettier.enable": false
}
118 changes: 59 additions & 59 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ For example:

```json
{
"scripts": {
"lint": "eslint .",
"lint:fix": "eslint . --fix"
}
"scripts": {
"lint": "eslint .",
"lint:fix": "eslint . --fix"
}
}
```

Expand All @@ -54,47 +54,47 @@ Install [VS Code ESLint extension](https://marketplace.visualstudio.com/items?it

```json
{
// Disable the default formatter, use eslint instead
"prettier.enable": false,
"editor.formatOnSave": false,

// Auto-fix on save
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
"source.organizeImports": true
},

// Silent the stylistic rules in your IDS, but still auto-fix them
"eslint.rules.customizations": [
{ "rule": "style/*", "severity": "off", "fixable": true },
{ "rule": "format/*", "severity": "off", "fixable": true },
{ "rule": "*-indent", "severity": "off", "fixable": true },
{ "rule": "*-spacing", "severity": "off", "fixable": true },
{ "rule": "*-spaces", "severity": "off", "fixable": true },
{ "rule": "*-order", "severity": "off", "fixable": true },
{ "rule": "*-dangle", "severity": "off", "fixable": true },
{ "rule": "*-newline", "severity": "off", "fixable": true },
{ "rule": "*quotes", "severity": "off", "fixable": true },
{ "rule": "*semi", "severity": "off", "fixable": true }
],

// Enable eslint for all supported languages
"eslint.validate": [
"javascript",
"javascriptreact",
"typescript",
"typescriptreact",
"html",
"markdown",
"json",
"jsonc",
"yaml",
"toml",
"xml",
"css",
"less",
"scss"
]
// Disable the default formatter, use eslint instead
"prettier.enable": false,
"editor.formatOnSave": false,

// Auto-fix on save
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
"source.organizeImports": true
},

// Silent the stylistic rules in your IDS, but still auto-fix them
"eslint.rules.customizations": [
{ "rule": "style/*", "severity": "off", "fixable": true },
{ "rule": "format/*", "severity": "off", "fixable": true },
{ "rule": "*-indent", "severity": "off", "fixable": true },
{ "rule": "*-spacing", "severity": "off", "fixable": true },
{ "rule": "*-spaces", "severity": "off", "fixable": true },
{ "rule": "*-order", "severity": "off", "fixable": true },
{ "rule": "*-dangle", "severity": "off", "fixable": true },
{ "rule": "*-newline", "severity": "off", "fixable": true },
{ "rule": "*quotes", "severity": "off", "fixable": true },
{ "rule": "*semi", "severity": "off", "fixable": true }
],

// Enable eslint for all supported languages
"eslint.validate": [
"javascript",
"javascriptreact",
"typescript",
"typescriptreact",
"html",
"markdown",
"json",
"jsonc",
"yaml",
"toml",
"xml",
"css",
"less",
"scss"
]
}
```

Expand All @@ -107,7 +107,7 @@ To enable React support, you need to explicitly turn it on:
import oncourse from '@oncoursesystems/eslint-config';

export default oncourse({
react: true,
react: true,
});
```

Expand All @@ -130,7 +130,7 @@ To enable Sencha ExtJS support, you need to explicitly turn it on:
import oncourse from '@oncoursesystems/eslint-config';

export default oncourse({
react: true,
react: true,
});
```

Expand All @@ -155,18 +155,18 @@ Example:
import oncourse from '@oncoursesystems/eslint-config';

export default oncourse(
// Configure integrations here
{
formatters: false,
},
// Any additional objects will be passed in as ESLint Flat Configs
// The files config is optional, but can be used to specify which files to lint
{
files: ['src/**/*.ts', 'src/**/*.tsx'],
rules: {
'ts/typedef': 'off',
}
},
// Configure integrations here
{
formatters: false,
},
// Any additional objects will be passed in as ESLint Flat Configs
// The files config is optional, but can be used to specify which files to lint
{
files: ['src/**/*.ts', 'src/**/*.tsx'],
rules: {
'ts/typedef': 'off',
}
},
);
```

Expand Down
10 changes: 5 additions & 5 deletions eslint.config.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import oncourse from './src';

export default oncourse({
type: 'lib',
type: 'lib',
}, {
ignores: [
'fixtures',
'_fixtures',
],
ignores: [
'fixtures',
'_fixtures',
],
});
Loading

0 comments on commit 40cdeec

Please sign in to comment.