Fix siteUrl detection of no passed slug

Old check failed in corner cases like a slug of '0'
omeka · Feb 6, 2025 · 68ca95b · 68ca95b
1 parent c5ddfd1
commit 68ca95b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/application/src/Api/Representation/ItemRepresentation.php b/application/src/Api/Representation/ItemRepresentation.php
@@ -104,7 +104,7 @@ public function primaryMedia()
 
     public function siteUrl($siteSlug = null, $canonical = false)
     {
-        if (!$siteSlug) {
+        if ($siteSlug === null) {
             $siteSlug = $this->getServiceLocator()->get('Application')
                 ->getMvcEvent()->getRouteMatch()->getParam('site-slug');
         }

diff --git a/application/src/Api/Representation/ItemSetRepresentation.php b/application/src/Api/Representation/ItemSetRepresentation.php
@@ -73,7 +73,7 @@ public function primaryMedia()
 
     public function siteUrl($siteSlug = null, $canonical = false)
     {
-        if (!$siteSlug) {
+        if ($siteSlug === null) {
             $siteSlug = $this->getServiceLocator()->get('Application')
                 ->getMvcEvent()->getRouteMatch()->getParam('site-slug');
         }

diff --git a/application/src/Api/Representation/MediaRepresentation.php b/application/src/Api/Representation/MediaRepresentation.php
@@ -314,7 +314,7 @@ public function displayTitle($default = null, $lang = null)
 
     public function siteUrl($siteSlug = null, $canonical = false)
     {
-        if (!$siteSlug) {
+        if ($siteSlug === null) {
             $siteSlug = $this->getServiceLocator()->get('Application')
                 ->getMvcEvent()->getRouteMatch()->getParam('site-slug');
         }

diff --git a/application/src/Api/Representation/SitePageRepresentation.php b/application/src/Api/Representation/SitePageRepresentation.php
@@ -139,7 +139,7 @@ public function modified()
 
     public function siteUrl($siteSlug = null, $canonical = false)
     {
-        if (!$siteSlug) {
+        if ($siteSlug === null) {
             $siteSlug = $this->site()->slug();
         }
         $url = $this->getViewHelper('Url');

diff --git a/application/src/Api/Representation/SiteRepresentation.php b/application/src/Api/Representation/SiteRepresentation.php
@@ -257,7 +257,7 @@ public function owner()
 
     public function siteUrl($siteSlug = null, $canonical = false)
     {
-        if (!$siteSlug) {
+        if ($siteSlug === null) {
             $siteSlug = $this->slug();
         }
         $url = $this->getViewHelper('Url');