fix: Remove PTR from _include_change #10
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to synchronise PTR record from infoblox to netbox but unfortunately I have the following issue:
DEBUG NetBoxDNSProvider[netbox_preprod] record not supported as provider, ignoring: <PtrRecord PTR 300, 1.1.1.1.in-addr.arpa., ['tcs.tcs.']>
I guess this issue is related to the function _include_change.
I tested the change submitted in this PR with the following infrastructure without issue:
Here is the result
2025-02-12T14:36:16 [139906302902272] DEBUG Zone changes: zone=Zone<1.1.1.in-addr.arpa.>, create record=<PtrRecord PTR 300, 1.1.1.1.in-addr.arpa., ['tcs.tcs.']>
2025-02-12T14:36:16 [139906302902272] DEBUG Plan init: Creates=1, Updates=0, Deletes=0 Existing=0
2025-02-12T14:36:16 [139906302902272] INFO NetBoxDNSProvider[netbox_preprod] plan: Creates=1, Updates=0, Deletes=0, Existing Records=0
2025-02-12T14:36:16 [139906302902272] INFO Plan
1.1.1.in-addr.arpa.
netbox_preprod (NetBoxDNSProvider)
Create <PtrRecord PTR 300, 1.1.1.1.in-addr.arpa., ['tcs.tcs.']> (infoblox)
Summary: Creates=1, Updates=0, Deletes=0, Existing Records=0
Could you explain me why this function has been include in this plugin in version v0.3.4?
Thank you for your time