-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JTI Claim as a string instead of guid #682
base: master
Are you sure you want to change the base?
Conversation
Hi @sachinsatav, Thank you for your contribution! An internal ticket will created to be prioritized by the team. Internal Ref: OKTA-666194 |
Superseded by #685 |
…tribution (#685) * JTI Claim as a string instead of guid * - Test third party contribution - Update templates to port solution in codegen process - Update version --------- Co-authored-by: Sachin Satav <[email protected]>
Thanks for your contribution. This changed has been merged, and it's available in Okta.Sdk v7.0.2. |
Hello, @laura-rodriguez! Could this issue be re-opened, because when switching to v8 these changes were lost. |
Thanks for the heads up @shimbor . It seems we forgot to port this change to the codegen templates. Internal Ref: OKTA-745550 |
@sachinsatav @shimbor Is this still an issue in version 9? |
@bryanapellanes-okta I haven't used Okta SDK v9 yet so not really sure :( |
@bryanapellanes-okta, sorry, we also decided to switch to direct API calls as a safer approach. |
Summary
Latest Microsoft Identity Model package >7.0.0 and above no longer serializes Guid datatype ( see - https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/f5fef2269a6eea5ba52d707d7235acf6a504db9f/src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs#L860-L924) and instead throws an exception -
To fix this, I am making JTI as string.
Fixes #
N/A
Type of PR
Signoff