Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Parameter existence checking in functions treats $false value as no parameter" (#56) #80

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fix "Parameter existence checking in functions treats $false value as no parameter" (#56) #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c222e2
- Update they way we check params have been provided. We now use $PSC…
laura-rodriguez Feb 14, 2025
36e701a
Update tests
laura-rodriguez Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ $Manifest = @{


RootModule = 'Okta.PowerShell.psm1'
Guid = '{A2196AD3-A5D4-4CD2-967A-4D5EA1EE008E}' # Has to be static, otherwise each new build will be considered different module
Guid = '{E2BB23D9-1EB2-4082-B5E3-198D6F3FE65E}' # Has to be static, otherwise each new build will be considered different module

PowerShellVersion = '7.0'

CompatiblePSEditions = 'Core'
Expand Down
18 changes: 9 additions & 9 deletions openapi3/codegen-templates/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
$LocalVarUri = '{{{path}}}'
{{=< >=}}
<#pathParams>
if (!$<paramName>) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("<paramName>") -or $null -eq $<paramName>) {
throw "Error! The required parameter `<paramName>` missing when calling <operationId>."
}
$LocalVarUri = $LocalVarUri.replace('{<baseName>}', [System.Web.HTTPUtility]::UrlEncode($<paramName>))
</pathParams>
<={{ }}=>

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand All @@ -117,7 +117,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{#headerParams}}
{{#required}}
{{^isNullable}}
if (!${{{paramName}}}) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}") -or $null -eq ${{{paramName}}}) {
throw "Error! The required parameter `{{paramName}}` missing when calling {{operationId}}."
}
$LocalVarHeaderParameters['{{baseName}}'] = ${{{paramName}}}
Expand All @@ -126,7 +126,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{/required}}
{{^required}}
{{^isNullable}}
if (${{{paramName}}}) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}")) {
$LocalVarHeaderParameters['{{baseName}}'] = ${{{paramName}}}
}

Expand All @@ -140,7 +140,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{#queryParams}}
{{#required}}
{{^isNullable}}
if (!${{{paramName}}}) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}") -or $null -eq ${{{paramName}}}) {
throw "Error! The required parameter `{{paramName}}` missing when calling {{operationId}}."
}
$LocalVarQueryParameters['{{baseName}}'] = ${{{paramName}}}
Expand All @@ -149,7 +149,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{/required}}
{{^required}}
{{^isNullable}}
if (${{{paramName}}}) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}")) {
$LocalVarQueryParameters['{{baseName}}'] = ${{{paramName}}}
}

Expand All @@ -163,7 +163,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{#formParams}}
{{#required}}
{{^isNullable}}
if (!${{{paramName}}}) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}") -or $null -eq ${{{paramName}}}) {
throw "Error! The required parameter `{{paramName}}` missing when calling {{operationId}}."
}
$LocalVarFormParameters['{{baseName}}'] = ${{{paramName}}}
Expand All @@ -172,7 +172,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{/required}}
{{^required}}
{{^isNullable}}
if (${{{paramName}}}) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}")) {
$LocalVarFormParameters['{{baseName}}'] = ${{{paramName}}}
}

Expand All @@ -186,7 +186,7 @@ function {{{vendorExtensions.x-powershell-method-name}}} {
{{#bodyParam}}
{{#required}}
{{^isNullable}}
if (!${{{paramName}}}) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("{{{paramName}}}") -or $null -eq ${{{paramName}}}) {
throw "Error! The required parameter `{{paramName}}` missing when calling {{operationId}}."
}

Expand Down
86 changes: 43 additions & 43 deletions src/Okta.PowerShell/Api/OktaAgentPoolsApi.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,16 @@ function Invoke-OktaActivateAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}/activate'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling activateAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling activateAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -200,18 +200,18 @@ function New-OktaAgentPoolsUpdate {
$LocalVarContentTypes = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling createAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
}

if (!$AgentPoolUpdate) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("AgentPoolUpdate") -or $null -eq $AgentPoolUpdate) {
throw "Error! The required parameter `AgentPoolUpdate` missing when calling createAgentPoolsUpdate."
}

Expand Down Expand Up @@ -332,16 +332,16 @@ function Invoke-OktaDeactivateAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}/deactivate'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling deactivateAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling deactivateAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -455,16 +455,16 @@ function Invoke-OktaDeleteAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling deleteAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling deleteAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -585,21 +585,21 @@ function Get-OktaAgentPools {

$LocalVarUri = '/api/v1/agentPools'

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
}

if ($LimitPerPoolType) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("LimitPerPoolType")) {
$LocalVarQueryParameters['limitPerPoolType'] = $LimitPerPoolType
}

if ($PoolType) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolType")) {
$LocalVarQueryParameters['poolType'] = $PoolType
}

if ($After) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("After")) {
$LocalVarQueryParameters['after'] = $After
}

Expand Down Expand Up @@ -711,16 +711,16 @@ function Get-OktaAgentPoolsUpdateInstance {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling getAgentPoolsUpdateInstance."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling getAgentPoolsUpdateInstance."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -828,12 +828,12 @@ function Get-OktaAgentPoolsUpdateSettings {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/settings'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling getAgentPoolsUpdateSettings."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -947,18 +947,18 @@ function Get-OktaAgentPoolsUpdates {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling getAgentPoolsUpdates."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
}

if ($Scheduled) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Scheduled")) {
$LocalVarQueryParameters['scheduled'] = $Scheduled
}

Expand Down Expand Up @@ -1070,16 +1070,16 @@ function Suspend-OktaAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}/pause'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling pauseAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling pauseAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -1193,16 +1193,16 @@ function Resume-OktaAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}/resume'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling resumeAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling resumeAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -1316,16 +1316,16 @@ function Invoke-OktaRetryAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}/retry'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling retryAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling retryAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -1442,18 +1442,18 @@ function Set-OktaAgentPoolsUpdateSettings {
$LocalVarContentTypes = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/settings'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling setAgentPoolsUpdateSettings."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
}

if (!$AgentPoolUpdateSetting) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("AgentPoolUpdateSetting") -or $null -eq $AgentPoolUpdateSetting) {
throw "Error! The required parameter `AgentPoolUpdateSetting` missing when calling setAgentPoolsUpdateSettings."
}

Expand Down Expand Up @@ -1574,16 +1574,16 @@ function Stop-OktaAgentPoolsUpdate {
$LocalVarAccepts = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}/stop'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling stopAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling stopAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
Expand Down Expand Up @@ -1706,22 +1706,22 @@ function Update-OktaAgentPoolsUpdate {
$LocalVarContentTypes = @('application/json')

$LocalVarUri = '/api/v1/agentPools/{poolId}/updates/{updateId}'
if (!$PoolId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("PoolId") -or $null -eq $PoolId) {
throw "Error! The required parameter `PoolId` missing when calling updateAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{poolId}', [System.Web.HTTPUtility]::UrlEncode($PoolId))
if (!$UpdateId) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("UpdateId") -or $null -eq $UpdateId) {
throw "Error! The required parameter `UpdateId` missing when calling updateAgentPoolsUpdate."
}
$LocalVarUri = $LocalVarUri.replace('{updateId}', [System.Web.HTTPUtility]::UrlEncode($UpdateId))

if ($Uri) {
if ($PSCmdlet.MyInvocation.BoundParameters.ContainsKey("Uri")) {
$ParsedUri = Invoke-ParseAbsoluteUri -Uri $Uri
$LocalVarUri = $ParsedUri["RelativeUri"]
$LocalVarQueryParameters = $ParsedUri["QueryParameters"]
}

if (!$AgentPoolUpdate) {
if (!$PSCmdlet.MyInvocation.BoundParameters.ContainsKey("AgentPoolUpdate") -or $null -eq $AgentPoolUpdate) {
throw "Error! The required parameter `AgentPoolUpdate` missing when calling updateAgentPoolsUpdate."
}

Expand Down
Loading