Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib.d.ts #10

Closed
wants to merge 3 commits into from
Closed

Update lib.d.ts #10

wants to merge 3 commits into from

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Feb 21, 2022 •
edited
Loading

Updates lib.d.ts:

  • Adds option parameter jwksUri for custom JWKS to the TS interface.
  • Flags expectedNonce as optional in the verifyIdToken TS declaration.
  • Fixed broken links in comments

Resolves: #6 and okta/okta-oidc-js#1031

Based on PR okta/okta-oidc-js#1033

Internal ref: OKTA-420060

denys.oblohin added 3 commits February 23, 2022 12:21
@denysoblohin-okta denysoblohin-okta force-pushed the od-dts-jwksUri-OKTA-420060 branch from 44b7fa2 to 38e28b2 Compare February 23, 2022 10:22
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Feb 23, 2022
@eng-prod-CI-bot-okta
Updates lib.d.ts
bcbd94e 
OKTA-420060
<<<Jenkins Check-In of Tested SHA: 38e28b2 for [email protected]>>>
Artifact: okta-jwt-verifier-js
Files changed count: 3
PR Link: "#10"
This was referenced Jul 20, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu-okta shuowu-okta shuowu-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jwksUri option missing in type definitions
3 participants
@denysoblohin-okta @shuowu-okta @eng-prod-CI-bot-okta