Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature listprofiles (v2) #222

Closed
wants to merge 5 commits into from
Closed

Conversation

pmgalea
Copy link

@pmgalea pmgalea commented Jul 10, 2024

Adding command to list profiles in ~/.okta/okta.yaml
Updating CONTRIBUTING.md with signing instructions

Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmgalea :shipit:

@monde
Copy link
Collaborator

monde commented Jul 11, 2024

@pmgalea this is still blocked on the original commits not being signed. You can either rewrite your commits with your signature https://superuser.com/questions/397149/can-you-gpg-sign-old-commits . Or, it's probalbly easier to squash the five commits into one, that final commit will be signed:

git rebase -i HEAD~5

image
Clean up the message as you see fit ...
image
You can check that the squash is signed (this example is when I did this on my local copy git log -1 --stat=300,300 --show-signature)

Screenshot 2024-07-11 at 9 24 57 AM

Then

git push -f

@monde
Copy link
Collaborator

monde commented Jul 12, 2024

I've been waiting on this go into a release have ready, I'll bring the changes in a branch I control so our merge protections are satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants