Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

355 more translations #679

Merged
merged 24 commits into from
Dec 10, 2024
Merged

355 more translations #679

merged 24 commits into from
Dec 10, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Dec 5, 2024

This PR translates

  • the interface of the Metadata Panel
  • adds the keys for the Desktop Menu
  • translates the text from the main image of the Welcome Dialog/Banner
  • translates the help.yaml files in the main translation file.

TODOS:

  • translate Portal / CKAN / Zenodo and Github help files (?) Will we keep them or delete them? They are not being used right now in the app.

Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 25fd4f7
Status: ✅  Deploy successful!
Preview URL: https://65672132.opendataeditor.pages.dev
Branch Preview URL: https://355-more-translations.opendataeditor.pages.dev

View logs

@roll
Copy link
Collaborator

roll commented Dec 9, 2024

we need to define a strategy for importing the help files, do you have any suggestions @roll ?

Maybe it will be easier to move all the used help messages to the code?

@guergana guergana requested a review from roll December 9, 2024 16:24
@guergana
Copy link
Collaborator Author

@roll could you please re-review this PR since you had some comments? It's approved but to be sure your points are addressed properly.

@guergana guergana merged commit 01b5b60 into main Dec 10, 2024
9 checks passed
@guergana guergana deleted the 355-more-translations branch December 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up internationalization
3 participants