Hw2 #2
Open
Hw2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqus
approved these changes
Oct 22, 2021
index.html
Outdated
| <link rel="stylesheet" type="text/css" href="styles/style.css"> | ||
| </head> | ||
| <body> | ||
| <div class="card__wrapper"> |
There was a problem hiding this comment.
можно было бы добавить пару тройку семантических тегов
styles/style.css
Outdated
| } | ||
|
|
||
| .card__social-link__vk { | ||
| left: 144px; |
There was a problem hiding this comment.
это правило не работает для элементов без position: absolute/fixed
styles/style.css
Outdated
| .card__social-link { | ||
| width: 24px; | ||
| height: 24px; | ||
| top: 370px; |
There was a problem hiding this comment.
это правило не работает для элементов без position: absolute/fixed
styles/style.css
Outdated
| } | ||
|
|
||
| .card__social-link__ok { | ||
| left: 178px; |
There was a problem hiding this comment.
это правило не работает для элементов без position: absolute/fixed
styles/style.css
Outdated
| } | ||
|
|
||
| .card__social-link__git { | ||
| left: 212px; |
There was a problem hiding this comment.
это правило не работает для элементов без position: absolute/fixed
styles/style.css
Outdated
|
|
||
| .card__download-cv-button { | ||
| width: 168px; | ||
| height: 46px; |
There was a problem hiding this comment.
не нужно ограничивать размеры, пусть кнопка становится под размер контента. Сейчас, если контента станет больше будет такая картина
|
Замечания по 1 и 2 домашнему заданиям были исправлены. |
AlexanderKiselyov
added a commit
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Названия классов по технологии БЭМ.