Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dot on header section links #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Krishna100604
Copy link

@shivankacker can you merge this ? i have made changes

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for landing-ohc ready!

Name Link
🔨 Latest commit 153a85d
🔍 Latest deploy log https://app.netlify.com/sites/landing-ohc/deploys/67878d01dcc8c50008fa8a86
😎 Deploy Preview https://deploy-preview-51--landing-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishna100604

  • The dot does not react to change in the header style when scrolled. To replicate, go to the supporters page and scroll down (on desktop)
  • The dot can be enlarged and placed on the right side of the current link in mobile view.

@Krishna100604
Copy link
Author

Krishna100604 commented Jan 16, 2025

@Krishna100604

  • The dot does not react to change in the header style when scrolled. To replicate, go to the supporters page and scroll down (on desktop)
  • The dot can be enlarged and placed on the right side of the current link in mobile view.

** i have made it responsive for mobile screen as well but i think i should remove it for contact page as this page itself in home pagee so it is very complicated

image
** for hamburger i did like this and if you want for contact page i made it black dot as the background is white

@Krishna100604
Copy link
Author

Krishna100604 commented Jan 16, 2025

@shivankacker if you can approve this underline thing it is good and it won't have issue with any screen and and any scrolling thing
image
** you can see here
image
** also works perfectly in small screens

@shivankacker
Copy link
Member

@Krishna100604 we need it as a dot, the underline wont compliment the design.

  • In your screenshot, the dot in the hamburger menu can be right next to the link and bigger than that.
  • Make the dot change color if the header background changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants