Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign location card UI #6853

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

GokulramGHV
Copy link
Contributor

@GokulramGHV GokulramGHV commented Dec 12, 2023

WHAT

🤖[deprecated] Generated by Copilot at 47c1b4b

This pull request enhances the location management feature of the facility module by adding a responsive grid layout, showing more location details, and updating the LocationModel interface to match the backend API. The changes affect the LocationManagement.tsx and models.tsx files.

Proposed Changes

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 47c1b4b

  • Redesign the Location component to show more information and use a grid layout (link, link, link)
  • Add the location_type, created_date, and modified_date properties to the LocationModel interface in models.tsx (link)
  • Display the location_type as a badge next to the name, the middleware_address as a separate section, and the dates at the bottom of the Location component in LocationManagement.tsx (link)
  • Reposition and style the Edit and Manage Beds buttons in the Location component (link)
  • Use a grid layout with responsive columns for the PaginatedList.Items component and wrap it in a div with a w-full @container class in LocationManagement.tsx (link)

@GokulramGHV GokulramGHV requested a review from a team as a code owner December 12, 2023 13:03
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 2:27pm

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit eaf3ea2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6582f984fa8cf10008b25c61
😎 Deploy Preview https://deploy-preview-6853--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@GokulramGHV is it good for testing

@GokulramGHV
Copy link
Contributor Author

@nihal467 There are a few changes to be done, I'll complete and push the changes and then I'll let you know

@GokulramGHV
Copy link
Contributor Author

GokulramGHV commented Dec 20, 2023

@nihal467 As per the discussion with @gigincg, we can work on the other changes in the card such as colours for labels and displaying bed count by addressing them in separate issues after discussing with @aparnacoronasafe again.
This PR is ready to be tested.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 83c4524 into ohcnetwork:develop Dec 20, 2023
28 of 31 checks passed
Copy link

@GokulramGHV We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for Location Management Page
4 participants