Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix s3 client error on gcp #2359

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix s3 client error on gcp #2359

merged 1 commit into from
Aug 14, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 14, 2024

ACL param is not supported by buckets with uniform access control

added a new parameter to specify wether the buckets has fine grained acl

fixes ohcnetwork/care_fe#8325

@sainak sainak requested a review from a team as a code owner August 14, 2024 12:09
Copy link

sentry-io bot commented Aug 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: care/facility/api/serializers/facility.py

Function Unhandled Issue
save ClientError: An error occurred (InvalidArgument) when calling the PutObject operation: Invalid argument. ...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (2221b06) to head (a379fb1).

Files Patch % Lines
care/facility/api/serializers/facility.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2359      +/-   ##
===========================================
- Coverage    63.70%   63.69%   -0.01%     
===========================================
  Files          238      238              
  Lines        13378    13384       +6     
  Branches      1907     1908       +1     
===========================================
+ Hits          8522     8525       +3     
- Misses        4506     4509       +3     
  Partials       350      350              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gigincg gigincg merged commit e95d98d into develop Aug 14, 2024
9 of 11 checks passed
@gigincg gigincg deleted the sainak/fix/gcp-client-error branch August 14, 2024 12:37
gigincg pushed a commit that referenced this pull request Aug 14, 2024
fix s3 client error on gcp (#2359)

Co-authored-by: Aakash Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility Cover image upload is not working in Staging Branch
3 participants