Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add management command to load skills #1707

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Nov 10, 2023

Proposed Changes

  • add a new management command to load skills
  • update load_dummy_data command
  • update docs

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from Ashesh3 November 10, 2023 11:31
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (033d085) 60.75% compared to head (0016ff6) 60.70%.

Files Patch % Lines
care/users/management/commands/load_skill_data.py 0.00% 9 Missing ⚠️
...re/facility/management/commands/load_dummy_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   60.75%   60.70%   -0.06%     
==========================================
  Files         210      211       +1     
  Lines       11533    11543      +10     
  Branches     1644     1645       +1     
==========================================
  Hits         7007     7007              
- Misses       4285     4295      +10     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"obstetrician and Gynecologists",
"Oncologist",
"Oncology Surgeon",
"Opthalmologists",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of plural words, can we switch to singular form?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainak sainak requested a review from vigneshhari December 6, 2023 15:09
@sainak sainak force-pushed the sainak/fix/skill-data branch from 2cabba3 to 0016ff6 Compare December 6, 2023 15:12
@vigneshhari vigneshhari merged commit 8720fe4 into master Dec 7, 2023
7 of 9 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/skill-data branch December 7, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants