Fixed linting issue for actions, reducers, stores & themes

odota · Feb 22, 2018 · ea055ac · ea055ac
1 parent 4cd6394
commit ea055ac
Show file tree

Hide file tree

Showing 16 changed files with 32 additions and 44 deletions.
diff --git a/app/actions/match_details_act.js b/app/actions/match_details_act.js
@@ -30,13 +30,11 @@ export function fetchMatchDetails(matchId) {
     return dispatch => {
         dispatch(requestMatchDetails());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receiveMatchDetails(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH MATCH DETAILS ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyMatchDetails());
         });
     }

diff --git a/app/actions/peers_act.js b/app/actions/peers_act.js
@@ -29,17 +29,14 @@ function receiveEmptyPeers() {
 
 export function fetchPeers(playerId) {
     var endpoint = "players/" + playerId + "/peers";
-    console.log(endpoint);
     return dispatch => {
         dispatch(requestPeers());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receivePeers(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH PEERS ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyPeers());
         });
     }

diff --git a/app/actions/player_heroes_act.js b/app/actions/player_heroes_act.js
@@ -27,19 +27,16 @@ function receiveEmptyHeroes() {
     };
 }
 
-export function fetchHeroes(playerId, limit) {
+export function fetchHeroes(playerId) {
     var endpoint = "players/" + playerId + "/heroes";
-    console.log(endpoint);
     return dispatch => {
         dispatch(requestHeroes());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receiveHeroes(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH MATCHES ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyHeroes());
         });
     }

diff --git a/app/actions/player_matches_act.js b/app/actions/player_matches_act.js
@@ -71,7 +71,7 @@ export function fetchMatches(playerId, limit, projects, sortCategory, heroId, re
     var endpoint = "players/" + playerId + "/matches?limit=" + limit;
 
     if(projects){
-        for(i = 0; i < projects.length; i++) {
+        for(let i = 0; i < projects.length; i++) {
             endpoint += ("&project=" + projects[i]);
         }
     }
@@ -116,17 +116,14 @@ export function fetchMatches(playerId, limit, projects, sortCategory, heroId, re
         endpoint += ("&region=" + region);
     }
 
-    console.log(endpoint);
     return dispatch => {
         dispatch(requestMatches());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receiveMatches(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH MATCHES ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyMatches());
         })
     }

diff --git a/app/actions/player_overview_act.js b/app/actions/player_overview_act.js
@@ -52,13 +52,11 @@ export function fetchWl(playerId) {
     return dispatch => {
         dispatch(requestWl());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receiveWl(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH WL ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyWl());
         })
     }
@@ -69,13 +67,11 @@ export function fetchOverview(playerId) {
     return dispatch => {
         dispatch(requestOverview());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receiveOverview(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH OVERVIEW ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyOverview());
         });
     }

diff --git a/app/actions/player_search_act.js b/app/actions/player_search_act.js
@@ -30,7 +30,6 @@ export function fetchPlayers(playerName) {
     return dispatch => {
         dispatch(requestPlayers());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             if(json.length == 0) {
@@ -39,8 +38,7 @@ export function fetchPlayers(playerName) {
                 dispatch(receivePlayers(json));
             }
         })
-        .catch((error) => {
-            console.log("Action - FETCH PLAYERS ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyPlayers());
         })
     };

diff --git a/app/actions/records_act.js b/app/actions/records_act.js
@@ -3,7 +3,7 @@ import { fetchAPI } from '../utils/fetch';
 export const types = {
     REQUEST_RECORDS: 'REQUEST_RECORDS',
     RECEIVE_RECORDS: 'RECEIVE_RECORDS',
-    RECEIVE_EMPTY_RECORDS: RECEIVE_EMPTY_RECORDS
+    RECEIVE_EMPTY_RECORDS: 'RECEIVE_EMPTY_RECORDS'
 };
 
 function requestRecords() {
@@ -27,17 +27,14 @@ function receiveEmptyRecords() {
 
 export function fetchRecords(playerId) {
     var endpoint = "players/" + playerId + "/records";
-    console.log(endpoint);
     return dispatch => {
         dispatch(requestRecords());
 
-        var jsonData;
         return fetchAPI(endpoint)
         .then((json) => {
             dispatch(receiveRecords(json));
         })
-        .catch((error) => {
-            console.log("Action - FETCH RECORDS ERROR - " + error);
+        .catch(() => {
             dispatch(receiveEmptyRecords());
         })
     }

diff --git a/app/actions/settings_act.js b/app/actions/settings_act.js
@@ -62,8 +62,6 @@ export function changeTheme(themeSet) {
         secondLegend = Colors.illusionSecondLegend;
         legendHex = Colors.illusionLegendHex;
         legendTranslucent = Colors.illusionLegendTranslucent;
-    } else {
-        console.log(value);
     }
     return {
         type: types.CHANGE_THEME,

diff --git a/app/containers/Splash.js b/app/containers/Splash.js
@@ -44,9 +44,14 @@ class Splash extends Component {
         let tracker = new GoogleAnalyticsTracker('UA-107430194-1');
         this.props.actions.setGATracker(tracker);
         AsyncStorage.getItem("theme").then((value) => {
-            this.props.actions.changeTheme(value);
+            if(value) {
+                this.props.actions.changeTheme(value);
+            } else {
+                this.props.actions.changeTheme(1);
+            }
         })
         .catch((error) => {
+            console.log("NOT FOUND");
             this.props.actions.changeTheme(1);
         })
 

diff --git a/app/reducers/favourites_rdx.js b/app/reducers/favourites_rdx.js
@@ -9,7 +9,7 @@ export default function favouritesState(state = initialState, action = {}) {
             return Object.assign({}, state, { favourites: [...state.favourites, action.info] });
         case types.REMOVE_FAVOURITES:
             var index;
-            for(i = 0; i < state.favourites.length; i++) {
+            for(let i = 0; i < state.favourites.length; i++) {
                 if(state.favourites[i].account_id == action.id) {
                     index = i;
                 }

diff --git a/app/reducers/navigation_rdx.js b/app/reducers/navigation_rdx.js
@@ -9,6 +9,8 @@ export default function navigationState(state = initialState, action = {}) {
                     ...state,
                     homeTab: true
                 };
+            } else {
+                return state
             }
 
         case "REACT_NATIVE_ROUTER_FLUX_FOCUS":

diff --git a/app/reducers/player_matches_rdx.js b/app/reducers/player_matches_rdx.js
@@ -21,18 +21,20 @@ export default function playerMatchesState(state = initialState, action = {}) {
             return Object.assign({}, state, { sortField: action.sortField, sortDirection: sortDirection, matches });
         case types.SET_MAX_PAGES:
             return Object.assign({}, state, {maxPages: action.maxPages});
-        case types.NAVIGATE_NEXT_MATCHES:
-            newPage = state.page + action.amount;
+        case types.NAVIGATE_NEXT_MATCHES: {
+            let newPage = state.page + action.amount;
             if(newPage > state.maxPages) {
                 newPage = state.maxPages
             }
             return Object.assign({}, state, { page: newPage });
-        case types.NAVIGATE_PREVIOUS_MATCHES:
-            newPage = state.page - action.amount;
+        }
+        case types.NAVIGATE_PREVIOUS_MATCHES: {
+            let newPage = state.page - action.amount;
             if(newPage < 1) {
                 newPage = 1;
             }
             return Object.assign({}, state, { page: newPage });
+        }
         default:
             return state;
     }

diff --git a/app/stores/index.js b/app/stores/index.js
@@ -5,5 +5,4 @@ if (process.env.NODE_ENV === 'production') {
     module.exports = require('./configureStore.prod')
 } else {
     module.exports = require('./configureStore.dev');
-    console.log("process.env.NODE_ENV = " + process.env.NODE_ENV)
 }
diff --git a/app/themes/BaseStyles.js b/app/themes/BaseStyles.js
@@ -2,8 +2,6 @@ import Fonts from './Fonts';
 import Metrics from './Metrics';
 import Colors from './Colors';
 
-import { Platform } from 'react-native';
-
 const base = {
     navbar: {
         navBarContainer: {

diff --git a/app/themes/Metrics.js b/app/themes/Metrics.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Platform, Dimensions } from 'react-native';
 import DeviceInfo from 'react-native-device-info';
 

diff --git a/package.json b/package.json
@@ -5,7 +5,12 @@
   "scripts": {
     "start": "react-native start",
     "clear": "npm cache verify && watchman watch-del-all && rm -rf $TMPDIR/react-* && rm -rf $TMPDIR/react-native-packager-cache-* && rm -rf $TMPDIR/metro-bundler-cache-*",
-    "lint": "eslint app/*"
+    "lint": "eslint app/*",
+    "actions-lint": "eslint app/actions",
+    "themes-lint": "eslint app/themes",
+    "stores-lint": "eslint app/stores",
+    "reducers-lint": "eslint app/reducers",
+    "json-lint": "eslint app/json"
   },
   "dependencies": {
     "appcenter": "^1.1.0",