Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertJ tests #65

Merged
merged 20 commits into from
Oct 28, 2021
Merged

AssertJ tests #65

merged 20 commits into from
Oct 28, 2021

Conversation

Shubhamr837
Copy link
Contributor

@Shubhamr837 Shubhamr837 commented Jun 16, 2021

AssertJ test to test login, update, delete, reset and upload.

@odk-x-bot
Copy link

Can one of the admins verify this patch? Also need an authorization to run tests.

@linl33 linl33 requested review from linl33 and codeknight3 June 18, 2021 01:44
Copy link
Member

@linl33 linl33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on the UI test.

Could you also look into running the UI tests on a headless box? It would be good to know if it's possible to run theses tests on a headless server, or if a graphical environment is required.

</dependency>
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-swing-aut</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if there's a typo? I can't find this dependency (assertj-swing-aut).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to mention this. assertj/assertj-examples#41 (comment) .
I added this to my local maven repository using the same commands that we use for adding sync client https://github.com/odk-x/suitcase/blob/master/dependencies/mvn_local_installs.

ioPanelFixture.requireNotVisible(); // IOPanel should not be visible on starting the application
frame.panel("main_panel").requireVisible(); // MainPanel should be visible on start of the application
frame.button("login_button").click();
Pause.pause(15000); // Wait for 15 seconds for login to complete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to check for login completion or listen for login completion instead of waiting a fixed amount of time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way is to get the sync wrapper and check weather it is initialized or not using the isinitialized() method which is already there.
should I implement that?

@Shubhamr837 Shubhamr837 requested a review from linl33 June 29, 2021 17:52
@Shubhamr837 Shubhamr837 changed the title assertJ login test AssertJ tests Aug 21, 2021
@wbrunette
Copy link
Member

@Shubhamr837 can you fix the conflicts so I can merge?

@Shubhamr837
Copy link
Contributor Author

@wbrunette sure I will.

@wbrunette
Copy link
Member

@Shubhamr837 can you fix the conflicts so I can merge?

@Shubhamr837
Copy link
Contributor Author

@wbrunette Sorry for being late on this. I have resolved the conflicts and created a new pull request for test of the reset button as it was moved to a new tab.

@wbrunette wbrunette merged commit 9d856e7 into odk-x:gsoc-2021 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants