Add parameters to syncing binary images to decrease size #134
+111
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load all reduced-size images if wanted.
|
Can one of the admins verify this patch? Also need an authorization to run tests. |
|
runtests |
|
runtests |
1 similar comment
|
runtests |
wbrunette
changed the title
wbrunette
reviewed
Jul 22, 2019
| URI instanceFilesDownloadUri = wrapper.constructInstanceFileBulkDownloadUri(serverInstanceFileUri, instanceId); | ||
|
|
||
| ArrayList<OdkTablesFileManifestEntry> entries = new ArrayList<OdkTablesFileManifestEntry>(); | ||
| for (CommonFileAttachmentTerms cat : filesToDownload) { | ||
| OdkTablesFileManifestEntry entry = new OdkTablesFileManifestEntry(); | ||
| entry.filename = cat.rowPathUri; | ||
| entry.reduceFileSize = reduce ? "t" : "f"; |
There was a problem hiding this comment.
I strongly recommend to use "true" and "false" instead of "t" and "f" as you can then simply use the Boolean class to convert the parameters. Consistency is important and if it's meant as true and false then use true and false.
|
runtests |
clarlars
reviewed
Jul 22, 2019
| URI instanceFilesDownloadUri = wrapper.constructInstanceFileBulkDownloadUri(serverInstanceFileUri, instanceId); | ||
|
|
||
| ArrayList<OdkTablesFileManifestEntry> entries = new ArrayList<OdkTablesFileManifestEntry>(); | ||
| for (CommonFileAttachmentTerms cat : filesToDownload) { | ||
| OdkTablesFileManifestEntry entry = new OdkTablesFileManifestEntry(); | ||
| entry.filename = cat.rowPathUri; | ||
| entry.reduceFileSize = reduce ? "t" : "f"; |
There was a problem hiding this comment.
Also, OdkTablesFileManifestEntry is one of the classes found in the odk-rest-interface jar. In order for this change to work, the odk-rest-interface jar will need to be packaged with the change to OdkTablesManifestEntry in the sync-endpoint and put into androidlibrary under the androidlibrary/androidlibrary_lib/libs directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding ability to sync reduced-size image attachments for server and redownload all reduced-size images if ever wanted
depends on:
odk-x/sync-endpoint#20
odk-x/androidlibrary#127