Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: Alternative method of adding adb in PATH in Windows #292

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stephaniebeatrice
Copy link

Contributed additional information on how to add adb in the Windows' path after installing Android Studio.

@@ -243,6 +243,16 @@ For Windows
#. Click on :guilabel:`OK` and exit all of the windows.
#. Verify that you have made the change by closing all :program:`PowerShell` or :program:`cmd` windows and open a new one (so it picks up the change), and type

.. Outreachy 2024 Starter Contribution Guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we want to have documentation that is specific to Outreachy and 2024.

@@ -243,6 +243,16 @@ For Windows
#. Click on :guilabel:`OK` and exit all of the windows.
#. Verify that you have made the change by closing all :program:`PowerShell` or :program:`cmd` windows and open a new one (so it picks up the change), and type

.. Outreachy 2024 Starter Contribution Guide
.. Alternative way of adding adb in your Windows PATH
Alternatively, if you have installed Android Studio on your local computer, it is pre-installed with the platform tools, therefore you are required to add it to your path. You can do using the following steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First sentence here a bit long and confusing, second "You can do" missing "so"

.. Outreachy 2024 Starter Contribution Guide
.. Alternative way of adding adb in your Windows PATH
Alternatively, if you have installed Android Studio on your local computer, it is pre-installed with the platform tools, therefore you are required to add it to your path. You can do using the following steps:
#. Click on the Search bar on the task bar and type :guilabel:`Edit environmental variables for your account`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear what the task bar/search bar is.

.. Alternative way of adding adb in your Windows PATH
Alternatively, if you have installed Android Studio on your local computer, it is pre-installed with the platform tools, therefore you are required to add it to your path. You can do using the following steps:
#. Click on the Search bar on the task bar and type :guilabel:`Edit environmental variables for your account`.
#. Click on Environment Variables option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share screen shots for this? That would make it clearer.

@elmps2018 elmps2018 requested a review from wbrunette April 11, 2024 14:09
@stephaniebeatrice
Copy link
Author

I have made modifications to the previous contribution as per the provided feedback for better clarity. Here are the screenshots as requested that make the steps clearer:

Select the path variable in the User Variables section, then select Edit:

Screenshot 2024-04-20 185150

In the Edit environment variables window, select New and add this path to the new field: %USERPROFILE%\AppData\Local\Android\sdk\platform-tools:

Screenshot 2024-04-20 185205

@elmps2018
Copy link
Contributor

@stephaniebeatrice, thanks for working on these, but I am not seeing the screenshots referenced in the files or uploaded. I am just seeing them in your comment.

@elmps2018
Copy link
Contributor

@stephaniebeatrice thanks for working on this. Looks like some checks failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants