Wait for data root before loading filesystem #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgca
approved these changes
Aug 29, 2022
|
Testing with Firefox and Safari / Chrome, it works! Huzzah! I logged #46 to track perf slowness. |
jessmartin
reviewed
Aug 30, 2022
There was a problem hiding this comment.
Just a few thoughts as I was reading through this. Not urgent! @bgins @therealjeffg
| const checkDataRoot = async (username: string): Promise<void> => { | ||
| let dataRoot = await webnative.dataRoot.lookup(username) | ||
|
|
||
| if (dataRoot) return |
| if (dataRoot) return | ||
|
|
||
| return new Promise((resolve) => { | ||
| const maxRetries = 20 |
There was a problem hiding this comment.
@bgins Not familiar with TypeScript module best practices, but feels weird to define this constant here. The name is quite clear! I wondering if it should be moved to the top level of webnative.ts and commented? 🤔
Maybe we wait until we need a retry construct somewhere else?
Now that I'm thinking about it, should this retry behavior be handled by the WebNative library, perhaps with an exponential backoff? (future improvement, not for this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following features:
checkDataRootfunction that checks for a filesystem data rootThe
checkDataRootfunction prevents a newly linked device from attempting to load a filesystem whose data root is not yet available on DNS.While waiting for the data root and loading the filesystem, the newly linked device displays the loading filesystem modal.
Link to issue
Implements #2
Type of change