-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open gallery endpoints #734
Conversation
…data_product_list_with_conditions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 62.08% 62.23% +0.15%
==========================================
Files 50 50
Lines 9175 9151 -24
==========================================
- Hits 5696 5695 -1
+ Misses 3479 3456 -23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot comment the code, ok for the principle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard for me to really review, I didn't follow gallery development. So I just approve.
Following the request from @francoismg and @ferrigno , the following endpoints no longer require the token:
resolve_name
get_data_product_list_with_conditions
(it will be optional as a further check will be implemented in the gallery)get_data_product_list_by_source_name
(along with a small refactoring: it uses now, the more general drupal endpoint to get a list ofdata_product
s given a certain set of conditions)