Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open gallery endpoints #734

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Open gallery endpoints #734

merged 8 commits into from
Jan 28, 2025

Conversation

burnout87
Copy link
Collaborator

Following the request from @francoismg and @ferrigno , the following endpoints no longer require the token:

  • resolve_name
  • get_data_product_list_with_conditions (it will be optional as a further check will be implemented in the gallery)
  • get_data_product_list_by_source_name (along with a small refactoring: it uses now, the more general drupal endpoint to get a list of data_products given a certain set of conditions)

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 62.23%. Comparing base (bb62f68) to head (78d9157).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
cdci_data_analysis/flask_app/app.py 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   62.08%   62.23%   +0.15%     
==========================================
  Files          50       50              
  Lines        9175     9151      -24     
==========================================
- Hits         5696     5695       -1     
+ Misses       3479     3456      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

volodymyrss
volodymyrss previously approved these changes Jan 27, 2025
Copy link
Contributor

@ferrigno ferrigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot comment the code, ok for the principle

Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard for me to really review, I didn't follow gallery development. So I just approve.

@burnout87 burnout87 merged commit 3ccd4f4 into master Jan 28, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants