-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in case local resolver fails, fallback to the external resolver #712
Conversation
@@ -708,10 +751,21 @@ | |||
yield yaml.load(open(dispatcher_test_conf_with_gallery_fn), Loader=yaml.SafeLoader)['dispatcher'] | |||
|
|||
|
|||
@pytest.fixture | |||
def dispatcher_test_conf_with_gallery_invalid_local_resolver(dispatcher_test_conf_with_gallery_invalid_local_resolver_fn): | |||
yield yaml.load(open(dispatcher_test_conf_with_gallery_invalid_local_resolver_fn), Loader=yaml.SafeLoader)['dispatcher'] |
Check warning
Code scanning / CodeQL
File is not always closed Warning
|
||
@pytest.fixture | ||
def dispatcher_test_conf_with_vo_options(dispatcher_test_conf_with_vo_options_fn): | ||
yield yaml.load(open(dispatcher_test_conf_with_vo_options_fn), Loader=yaml.SafeLoader)['dispatcher'] |
Check warning
Code scanning / CodeQL
File is not always closed Warning
In case the local resolver is not reachable, then the external resolver is used. This is the same approach used by the frontend |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
- Coverage 62.40% 61.90% -0.51%
==========================================
Files 50 50
Lines 9002 9096 +94
==========================================
+ Hits 5618 5631 +13
- Misses 3384 3465 +81 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware resolver is used from the dispatcher. Is this only gallery-related?
This one is, at the moment, used for the gallery |
No description provided.