Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisations in Instrument lists #661

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Optimisations in Instrument lists #661

merged 10 commits into from
Feb 27, 2024

Conversation

dsavchenko
Copy link
Member

@dsavchenko dsavchenko commented Feb 21, 2024

This PR is a supporting for oda-hub/dispatcher-plugin-nb2workflow#90

  • importer.instrument_factory_list is now an iterator that stores instr_factory_list per-plugin (to properly deal with the new one in nb2w plugin).
  • Parameter.from_owl_url now accepts Ontology object (for optimisation)
  • Optimisation. In all iterations over instrument_factory_list the Instrument object is not built if we don't really need it, instead attributes of the factory function are checked. (Before, all Instrument instances of nb2w plugin were created in every request).

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 77.96610% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 61.26%. Comparing base (71c8ae0) to head (dad5c20).

Files Patch % Lines
cdci_data_analysis/flask_app/dispatcher_query.py 71.42% 8 Missing ⚠️
cdci_data_analysis/analysis/parameters.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage   61.24%   61.26%   +0.02%     
==========================================
  Files          48       48              
  Lines        8657     8690      +33     
==========================================
+ Hits         5302     5324      +22     
- Misses       3355     3366      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsavchenko dsavchenko changed the title instance_signature_from_owl Optimisations in Instrument lists Feb 25, 2024
@dsavchenko dsavchenko marked this pull request as ready for review February 25, 2024 23:25
cdci_data_analysis/analysis/parameters.py Outdated Show resolved Hide resolved
cdci_data_analysis/flask_app/app.py Outdated Show resolved Hide resolved
cdci_data_analysis/plugins/importer.py Show resolved Hide resolved
cdci_data_analysis/flask_app/dispatcher_query.py Outdated Show resolved Hide resolved
@dsavchenko dsavchenko requested a review from burnout87 February 26, 2024 15:29
@dsavchenko dsavchenko enabled auto-merge (squash) February 27, 2024 10:00
@dsavchenko dsavchenko merged commit 2696008 into master Feb 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants