Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logprobs Unit Test #183

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions serve/tests/unittest/test_engine_with_samplers.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,20 +342,30 @@ def _test_penalty(
def _test_logprobs(
model_artifact_path,
use_staging_engine,
max_num_sequences=4,
max_input_len=512,
num_requests=5,
top_logprobs=3,
max_num_batched_tokens=2048
):
prompt = "hi"
prompt = "hi could you please implement merge sort?"
engine = create_engine(
model_artifact_path,
use_staging_engine,
max_num_sequences,
max_input_len,
max_num_batched_tokens,
)
s = 113
requests = [create_request(idx=str(n-s), prompt=prompt, temp=0, max_tokens=n, stop=None, ignore_eos=True, top_logprobs=top_logprobs, logprobs=True) for n in range(s, s+num_requests)]
requests = [
create_request(
idx=str(n),
prompt=prompt,
temp=0,
freq_pen=0,
pre_pen=0,
max_tokens=300,
stop=None,
ignore_eos=True,
top_logprobs=top_logprobs,
logprobs=True
) for n in range(num_requests)
]
engine.add(requests)

generated = ["" for _ in range(num_requests)]
Expand All @@ -366,7 +376,7 @@ def _test_logprobs(
assert len(res.sequences) == 1
seq = res.sequences[0]

assert seq.finish_reason is not None or len(list(seq.logprobs.content[0]["top_logprobs"])) == top_logprobs
assert seq.finish_reason is not None or len(seq.logprob_info[0].top_logprobs) == top_logprobs

if seq.is_finished:
assert seq.num_generated_tokens == requests[int(res.request_id)].stopping_criteria.max_tokens
Expand Down
Loading