Fixes

ocsigen · Jan 29, 2025 · 89c0234 · 89c0234
1 parent d7a538f
commit 89c0234
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -153,9 +153,10 @@ jobs:
       - run: opam exec -- make tests
         if: ${{ !matrix.skip-test }}
 
-      - run: |
-          opam exec -- dune build @all @runtest @runtest-js --profile with-effects
-          opam exec -- dune build @all @runtest @runtest-js --profile with-effects-double-translation
+      - run: opam exec -- dune build @all @runtest @runtest-js --profile with-effects
+        if: ${{ !matrix.skip-effects }}
+
+      - run: opam exec -- dune build @all @runtest @runtest-js --profile with-effects-double-translation
         if: ${{ !matrix.skip-effects }}
 
       - run: opam exec -- git diff --exit-code

diff --git a/compiler/tests-dynlink-js/effects_flags.ml b/compiler/tests-dynlink-js/effects_flags.ml
@@ -6,7 +6,7 @@ let () =
   let major = String.split_on_char '.' Sys.ocaml_version |> List.hd |> int_of_string in
   let has_effect l =
     match l with
-    | [ "with-effects" | "with-effects-double-translation" ] -> major >= 5
+    | [ ("with-effects" | "with-effects-double-translation") ] -> major >= 5
     | _ -> false
   in
   let aux l = enable (has_effect l) "effects" in