-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates on the test cases and minor fixes in the rt* scripts #68
base: feature/coastal_app
Are you sure you want to change the base?
Changes from 18 commits
edb0b64
a3207db
c4e2224
b064a8c
6ceb3b5
bb24454
aff1b8f
28ada34
af89fa9
24422a6
07c7da1
18a2f7e
58c39a6
32ae224
05e7803
371a525
1af77ba
cf8b62a
5bef0d1
13cd5b1
1ecd724
dd4685c
3c84ca2
b293804
be1e69e
c3dc345
607659f
6191e39
01e71c5
94ac03c
d6ca914
fb74df2
985194a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if we move UFS coastal README to app level then we need to revert back the name of this file. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
[![Read The Docs Status](https://readthedocs.org/projects/ufs-weather-model/badge/?badge=latest)](http://ufs-weather-model.readthedocs.io/) | ||
|
||
# ufs-weather-model | ||
|
||
This is the UFS weather model source code | ||
|
||
# Where to find information | ||
|
||
Start at the [wiki](https://github.com/ufs-community/ufs-weather-model/wiki) which has quick start instructions. | ||
|
||
[User's reference guide](http://ufs-weather-model.readthedocs.io/) is hosted on read the docs. | ||
|
||
# What files are what | ||
|
||
The top level directory structure groups source code and input files as follow: | ||
|
||
| File/directory | Purpose | | ||
| -------------- | ------- | | ||
| ```LICENSE.md``` | A copy of the GNU Lesser General Public License, Version 3. | | ||
| ```README.md``` | This file with basic pointers to more information. | | ||
| ```NEMS/``` | Contains NOAA Environmental Modeling System source code and nems compset run scripts. | | ||
| ```CMEPS-interface/``` | Contains CMEPS mediator | | ||
| ```FV3/``` | Contains FV3 atmosphere model component including FV3 dynamical core, dynamics to physics driver, physics and IO. | | ||
| ```DATM/``` | Contains Data Atmosphere model component | | ||
| ```WW3/``` | Contains community wave modeling framework WW3. | | ||
| ```MOM6-interface/``` | Contains MOM6 ocean model component | | ||
| ```CICE-interface/``` | Contains CICE sea-ice model component including CICE6 and Icepack | | ||
| ```stochastic_physics/``` | Contains the stochastic physics source code. | | ||
| ```cmake/``` | Contains compile option files on various platforms. | | ||
| ```modulefiles/``` | Contains module files on various platforms. | | ||
| ```tests/``` | Regression and unit testing framework scripts. | | ||
| ```build.sh``` | Script to build the model executable. (also used by `tests/`) | | ||
|
||
E.g. use of `build.sh` to build the coupled model with `FV3_GFS_v15p2` as the CCPP suite. | ||
``` | ||
$> CMAKE_FLAGS="-DAPP=S2S" CCPP_SUITES="FV3_GFS_v15p2" ./build.sh | ||
``` | ||
The build system is regularly tested with [Tier-1 and Tier-2 platforms]( | ||
https://github.com/ufs-community/ufs-weather-model/wiki/Regression-Test-Policy-for-Weather-Model-Platforms-and-Compilers). | ||
Configurations for other platforms that are available with UFS should be used with the understanding that they are not regularly | ||
tested and users will have to adapt those to make it work. | ||
|
||
# Disclaimer | ||
|
||
The United States Department of Commerce (DOC) GitHub project code is provided | ||
on an "as is" basis and the user assumes responsibility for its use. DOC has | ||
relinquished control of the information and no longer has responsibility to | ||
protect the integrity, confidentiality, or availability of the information. Any | ||
claims against the Department of Commerce stemming from the use of its GitHub | ||
project will be governed by all applicable Federal law. Any reference to | ||
specific commercial products, processes, or services by service mark, | ||
trademark, manufacturer, or otherwise, does not constitute or imply their | ||
endorsement, recommendation or favoring by the Department of Commerce. The | ||
Department of Commerce seal and logo, or the seal and logo of a DOC bureau, | ||
shall not be used in any manner to imply endorsement of any commercial product | ||
or activity by DOC or the United States Government. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am syncing both SCHSIM and SCHSIM-ESMF at this point and pointing their master branch. So, once I finish testing that and syncing ufs-coastal with ufs-weather-model, this branch needs to be synced. Then, these will disappear from the PR. |
+2 −2 | Dockerfile | |
+18 −0 | cmake/SCHISM.homebrew.gcc-openmpi | |
+15 −0 | cmake/SCHISM.local.kuro | |
+16 −0 | cmake/SCHISM.macports.gcc-openmpi | |
+4 −0 | cmake/SCHISMCompile.cmake | |
+35 −7 | conda.recipe/README | |
+29 −16 | conda.recipe/build.sh | |
+64 −7 | conda.recipe/conda_build_config.yaml | |
+0 −20 | conda.recipe/cross-linux.cmake | |
+39 −42 | conda.recipe/meta.yaml | |
+8 −3 | docs/getting-started/test_suite.md | |
+3 −3 | docs/getting-started/visualization.md | |
+6 −1 | docs/schism/overview.md | |
+1 −1 | src/Hydro/misc_subs.F90 | |
+0 −6 | src/Hydro/schism_step.F90 | |
+26 −34 | src/Utility/Cluster_files/auto_hotstart.py | |
+2 −0 | src/Utility/Cluster_files/modules.kuro | |
+8 −0 | src/Utility/Cluster_files/run_kuro | |
+62 −49 | src/WWMIII/wwm_coupl_selfe.F90 | |
+1 −1 | src/WWMIII/wwm_datapl.F90 |
+8 −5 | src/schism/schism_esmf_util.F90 | |
+2 −2 | src/schism/schism_nuopc_cap.F90 |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, I think we need to get rid of entire images folder. They seems also belong to old version of the model (CoastalApp). |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is not required. If we have actions in the app level we could show their status dynamically in the README page. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we don't need to adjust these. I am currently syncing ufs-coastal and if there is a still issue with those queue names. We could open an issue in ufs-weather-model level and make the changes over there. We might also adjust rt.sh to allow using user specified queue names from command line rather than hardcoding in her. That will bring more flexibility to the RT system. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is better to keep only fully tested configurations in the rt_coastal.conf. It would be nice to create another file (rt_coastal_tmp.conf etc.) for the rest. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
############################################################################### | ||
# | ||
# ADCIRC coupled florence_hsofs_atm2adc2ww3 configuration | ||
# | ||
############################################################################### | ||
|
||
export TEST_DESCR="Compare florence_hsofs_atm2adc2ww3 results with previous trunk version" | ||
|
||
export CNTL_DIR=coastal_florence_hsofs_atm2adc2ww3 | ||
|
||
export LIST_FILES="fort.74.nc \ | ||
fort.73.nc \ | ||
fort.64.nc \ | ||
fort.63.nc \ | ||
fort.61.nc \ | ||
ufs.cpld.cpl.hi.2018-09-10-00000.nc \ | ||
ufs.cpld.cpl.hi.2018-09-11-00000.nc \ | ||
ufs.cpld.cpl.hi.2018-09-12-00000.nc" | ||
|
||
# deafult options | ||
export_coastal | ||
|
||
# model_configure | ||
export SYEAR=2018 | ||
export SMONTH=09 | ||
export SDAY=10 | ||
export SHOUR=00 | ||
export FHMAX=1 | ||
#export FHMAX=7 | ||
export FHROT=0 | ||
# not used | ||
export DT_ATMOS=720 | ||
export RESTART_INTERVAL=0 | ||
export QUILTING=.true. | ||
export QUILTING_RESTART=.false. | ||
export WRITE_GROUP=1 | ||
export WRTTASK_PER_GROUP=6 | ||
export ITASKS=1 | ||
export OUTPUT_HISTORY=.true. | ||
export WRITE_DOPOST=.false. | ||
export NUM_FILES=2 | ||
export FILENAME_BASE="'atm' 'sfc'" | ||
export OUTPUT_GRID="'cubed_sphere_grid'" | ||
export OUTPUT_FILE="'netcdf'" | ||
export IDEFLATE=0 | ||
export NBITS=0 | ||
export ICHUNK2D=0 | ||
export JCHUNK2D=0 | ||
export ICHUNK3D=0 | ||
export JCHUNK3D=0 | ||
export KCHUNK3D=0 | ||
export IMO=384 | ||
export JMO=190 | ||
export WRITE_NSFLIP=.false. | ||
export OUTPUT_FH="12 -1" | ||
export IAU_OFFSET=0 | ||
if [[ " hera orion hercules gaea jet " =~ " ${MACHINE_ID} " ]] ; then | ||
ZSTANDARD_LEVEL=5 | ||
fi | ||
|
||
# datm | ||
export DATM_CDEPS=true | ||
export DATM_STREAM_CONFIGURE=datm.streams.coastal.IN | ||
export atm_datamode="ATMMESH" | ||
export MESH_ATM="Wind_Pressure_HWRF_Florence_ExtendedSmooth_ESMFmesh.nc" | ||
export ATM_NX_GLB=3241 | ||
export ATM_NY_GLB=2761 | ||
export EXPORT_ALL=.true. | ||
export FILENAME_BASE='atmmesh.' | ||
export STREAM_VECTORS="null" | ||
export stream_files="\"INPUT/Wind_Pressure_HWRF_Florence_ExtendedSmooth.nc\"" | ||
export stream_variables="\"uwnd Sa_u10m\" \"vwnd Sa_v10m\" \"P Sa_pslv\"" | ||
export mapalgo=redist | ||
export dtlimit=1.5 | ||
export STREAM_OFFSET=0 | ||
|
||
# datm/ocean | ||
export HURR="Florence" | ||
export CPL_CONF="atm2adc2ww3" | ||
|
||
# pes | ||
export ATM_compute_tasks=20 | ||
export OCN_tasks=240 | ||
export WAV_tasks=480 | ||
|
||
export WLCLK=120 | ||
|
||
# configuration | ||
export MODEL_CONFIGURE=model_configure.IN | ||
export UFS_CONFIGURE=ufs.configure.coastal_datm_ocn_wav.IN | ||
export med_model=cmeps | ||
export med_omp_num_threads=1 | ||
export atm_model=datm | ||
export atm_omp_num_threads=1 | ||
export ocn_model=adcirc | ||
export ocn_omp_num_threads=1 | ||
export wav_model=ww3 | ||
export wav_omp_num_threads=1 | ||
export MESH_WAV="HSOFS_ESMFmesh.nc" | ||
export coupling_interval_slow_sec=3600 | ||
export RESTART_N=12 | ||
export RUNTYPE=startup | ||
export CPLMODE=coastal | ||
export meshloc=element | ||
|
||
# input files | ||
export FV3_RUN="coastal_datm_atmmesh.IN coastal_schism_run.IN coastal_ww3_run.IN" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvelissariou1 @janahaddad I think we will move this UFS Coastal specific readme file to app level (ufs-coastal-app). Right. This also includes the images. BTW, I am not comfortable to use image files in the documentation at least in the README file. This will make our life harder when we need to change those information and we will need to recreate those files. I think it is better to go with plain text. Anyway let me know what you think.