Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed read_csv call syntax from delim_whitespace to sep #195

Merged

Conversation

gutierrad
Copy link
Contributor

Hi,

I kept receiving a warning when loading fort.14 files that pandas has deprecated delim_whitespace argument from read_csv:
FutureWarning: The 'delim_whitespace' keyword in pd.read_csv is deprecated and will be removed in a future version. Use ``sep='\s+'`` instead
I have changed it to the suggested sep='\s+' so that the warning doesn't show up.

Hope this helps,
David

@SorooshMani-NOAA
Copy link
Collaborator

@WPringle all tests seem to pass, it is OK to merge this?

@WPringle WPringle self-requested a review August 12, 2024 17:17
Copy link
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SorooshMani-NOAA
Copy link
Collaborator

@gutierrad I'll merge this and we can also tag it with a updated version, but we have some permission issues that we're still trying to figure out to be able to release the latest version on PyPI.

@SorooshMani-NOAA SorooshMani-NOAA merged commit 0eb84de into oceanmodeling:main Aug 12, 2024
9 of 10 checks passed
@gutierrad
Copy link
Contributor Author

Great! No worries. For the time being I'll use the "downloaded" version instead of the package.
Thank you very much

@gutierrad gutierrad deleted the remove_delim_whitespace branch August 12, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants