abstract call method

oceanmodeling · Mar 5, 2021 · cee6d90 · cee6d90
1 parent 0505fb3
commit cee6d90
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 15 deletions.
diff --git a/adcircpy/forcing/tides/dataset.py b/adcircpy/forcing/tides/dataset.py
@@ -21,7 +21,14 @@ def __call__(
             constituent: str,
             vertices: np.ndarray
     ) -> (np.ndarray, np.ndarray):
-        raise NotImplementedError
+        """
+        get tidal ampltidue and phase
+        :param constituent: tidal constituent
+        :param vertices: XY locations at which to sample (Mx2)
+        :return: amplitude and phase arrays at given locations
+        """
+        return self.get_amplitude(constituent, vertices), \
+               self.get_phase(constituent, vertices)
 
     @abstractmethod
     def get_amplitude(

diff --git a/adcircpy/forcing/tides/hamtide.py b/adcircpy/forcing/tides/hamtide.py
@@ -40,13 +40,6 @@ def __init__(self, hamtide_dataset_directory: PathLike = None):
 
         self.datasets = datasets
 
-    def __call__(
-            self,
-            constituent: str,
-            vertices: np.ndarray
-    ) -> (np.ndarray, np.ndarray):
-        return self.get_amplitude(constituent, vertices), \
-               self.get_phase(constituent, vertices)
 
     def get_amplitude(
             self,

diff --git a/adcircpy/forcing/tides/tpxo.py b/adcircpy/forcing/tides/tpxo.py
@@ -40,13 +40,6 @@ def __init__(self, tpxo_dataset_filename: PathLike = None):
                     f'"{self.DEFAULT_PATH}"'
             )
 
-    def __call__(self, constituent: str, vertices) -> (np.ndarray, np.ndarray):
-        """
-        "method" can be 'spline' or any string accepted by griddata()'s method
-        kwarg.
-        """
-        return self.get_amplitude(constituent, vertices), \
-               self.get_phase(constituent, vertices)
 
     def get_amplitude(
             self,