Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved validation of maxgrid #58

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Moved validation of maxgrid #58

merged 2 commits into from
Sep 3, 2024

Conversation

wleoncio
Copy link
Member

@wleoncio wleoncio commented Sep 3, 2024

See conversation on issue #54 for details.

maxgrid looks like a mandatory parameter, but it is only used when
my_lambda is passed. For example, cv_MADMMplasso() does not pass those
arguments (or more appropriately, it passes my_lambda as NULL).
@wleoncio wleoncio requested a review from Theo-qua September 3, 2024 04:56
@wleoncio wleoncio linked an issue Sep 3, 2024 that may be closed by this pull request
@Theo-qua Theo-qua merged commit eb848a7 into main Sep 3, 2024
13 checks passed
@wleoncio wleoncio deleted the issue-57 branch September 3, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict condition to only when my_lambda = NULL
2 participants