Display the version number of packages flagged with avoid-version/deprecated gray #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
added a commit
to kit-ty-kate/opam-repository
that referenced
this pull request
Jan 7, 2025
This was referenced Jan 7, 2025
rjbou
reviewed
Jan 15, 2025
kit-ty-kate
force-pushed
the
show-avoid-version
branch
from
df30e1e to
6413048
Compare
|
Per discussion at today's meeting, i've switched the color to gray instead of crossed+yellow to avoid confusion on whether it is possible to install the affected version or not |
kit-ty-kate
force-pushed
the
show-avoid-version
branch
from
6413048 to
be365d8
Compare
|
rebased |
rjbou
changed the title
rjbou
reviewed
Jan 20, 2025
…version/deprecated gray
…m show Co-authored-by: R. Boujbel <[email protected]>
kit-ty-kate
force-pushed
the
show-avoid-version
branch
from
e9ea9f7 to
f3b90c8
Compare
|
If it is possible, can you add a picture with the gray version? |
|
|
kit-ty-kate
added a commit
to kit-ty-kate/opam-repository
that referenced
this pull request
Jan 20, 2025
…et with avoid-version See ocaml/opam#6358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of the new output with
opam show ocaml-base-compiler:Fixes #6354, probably the less intrusive solution if the color scheme works for you. Compared to removing them completely as suggested in the ticket, it brings an issue of clarity of meaning between what yellow or red means, although this concern seems pretty minimal to me compared to the other UX concerns brought by a potential addition of
--all.