Apply suggestions from code review

Co-authored-by: Etienne Millon <[email protected]>
ocaml · Nov 21, 2023 · f5c70e2 · f5c70e2
1 parent ae7cf8d
commit f5c70e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -161,4 +161,4 @@ users)
   * `OpamSystem.mk_temp_dir`: resolve real path with `OpamSystem.real_path` before returning it [#5654 @rjbou]
   * `OpamSystem.resolve_command`: in command resolution path, check that the file is not a directory and that it is a regular file [#5606 @rjbou - fix #5585 #5597 #5650 #5626]
   * `OpamStd.Config.env_level`: fix level parsing, it was inverted (eg, "no" gives level 1, and "yes" level 0) [#5686 @smorimoto]
-  * `OpamConsole`: add `disable_carriage_return` to disable automatic addition of carriage return (`set_bynari_mode_out`) on stdou & stderr on Windows if out is not tty [#5715 @rjbou]
+  * `OpamConsole`: add `disable_carriage_return` to disable automatic addition of carriage return (`set_binary_mode_out`) on stdout & stderr on Windows if out is not tty [#5715 @rjbou]
diff --git a/src/core/opamConsole.ml b/src/core/opamConsole.ml
@@ -41,7 +41,7 @@ let disable_carriage_return =
   if Sys.win32 && not OpamStd.Sys.tty_out then
     fun () ->
       set_binary_mode_out stdout true;
-      set_binary_mode_out stdout true
+      set_binary_mode_out stderr true
   else
   fun () -> ()