Fix segfault in process ancestry code

The current pointer would end up pointing to a freed block if realloc had to move the process list.
ocaml · Nov 7, 2023 · 9ec78ae · 9ec78ae
1 parent 074b4c9
commit 9ec78ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/master_changes.md b/master_changes.md
@@ -105,7 +105,7 @@ users)
 ## Internal
 
 ## Internal: Windows
-  * Fix sporadic crash in shell detection (seen in native containers) [#5714 @dra27]
+  * Fix sporadic crash and segfault in shell detection (seen in native containers) [#5714 @dra27]
 
 ## Test
 

diff --git a/src/stubs/win32/opamWindows.c b/src/stubs/win32/opamWindows.c
@@ -675,6 +675,7 @@ CAMLprim value OPAMW_GetProcessAncestry(value unit)
                     read_entry = FALSE;
                     break;
                   } else {
+                    cur = ptr + (cur - processes);
                     processes = ptr;
                   }
                 }