Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 packages from lexifi/landmarks at 1.5 #27263

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

edwinans
Copy link
Contributor

This pull-request concerns:

  • landmarks.1.5: A simple profiling library
  • landmarks-ppx.1.5: Preprocessor instrumenting code using the landmarks library


🐫 Pull-request generated by opam-publish v2.5.0

@edwinans edwinans force-pushed the opam-publish-landmarks.1.5 branch 3 times, most recently from c846b60 to 756853a Compare January 15, 2025 17:28
]
]
dev-repo: "git+https://github.com/LexiFi/landmarks.git"
available: arch = "x86_64" | arch = "x86_32" | arch = "arm64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
available: arch = "x86_64" | arch = "x86_32" | arch = "arm64"
available: arch = "x86_64" | arch = "x86_32" | arch = "arm64"
conflicts: [ "ocaml-option-bytecode-only" ]

since x86_32 fails on 5.* with

#=== ERROR while compiling landmarks.1.5 ======================================#
# context              2.4.0~alpha1~dev | linux/x86_32 | ocaml-base-compiler.5.3.0 | pinned(https://github.com/lexifi/landmarks/archive/refs/tags/v1.5.tar.gz)
# path                 ~/.opam/5.3/.opam-switch/build/landmarks.1.5
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p landmarks -j 71 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/landmarks-7-d72438.env
# output-file          ~/.opam/log/landmarks-7-d72438.out
### output ###
# File "tests/alloc/dune", lines 6-10, characters 0-74:
#  6 | (rule
#  7 |  (ignore-stderr
#  8 |   (with-stdout-to
#  9 |    test.out
# 10 |    (run ./test.exe))))
# Error: No rule found for tests/alloc/test.exe

due to the fact that dune is not able to compile the executable but only the bytecode version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On x86_32 (ocaml 4.14) the tests fail with


#=== ERROR while compiling landmarks.1.5 ======================================#
# context              2.4.0~alpha1~dev | linux/x86_32 | ocaml-base-compiler.4.14.2 | pinned(https://github.com/lexifi/landmarks/archive/refs/tags/v1.5.tar.gz)
# path                 ~/.opam/4.14/.opam-switch/build/landmarks.1.5
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p landmarks -j 71 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/landmarks-7-40d7ed.env
# output-file          ~/.opam/log/landmarks-7-40d7ed.out
### output ###
# File "tests/alloc/test.out.expected", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/tests/alloc/test.out.expected _build/default/tests/alloc/test.out
# diff --git a/_build/default/tests/alloc/test.out.expected b/_build/default/tests/alloc/test.out
# index 934999a..e772b3f 100644
# --- a/_build/default/tests/alloc/test.out.expected
# +++ b/_build/default/tests/alloc/test.out
# @@ -1,3 +1,3 @@
#  Allocations:
# -0
# +44
#  0

Is that expected or fine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Is that expected or fine?

No, I am going to adapt it.

Is it ok to fail on "freebsd (experimental)"?

@edwinans edwinans force-pushed the opam-publish-landmarks.1.5 branch from 756853a to 72554b8 Compare January 21, 2025 11:23
@mseri
Copy link
Member

mseri commented Jan 22, 2025

Thanks, looks good now.
The freebsd failure is independent of this, it is not a blocker

@mseri mseri merged commit a12dee6 into ocaml:master Jan 22, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants