Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] carton (4 packages) (1.0.0) #27262

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

dinosaure
Copy link
Contributor

Implementation of PACKv2 file in OCaml

CHANGES:
  • New version of Carton

@mseri
Copy link
Member

mseri commented Jan 15, 2025

There seems to be a failure that needs to be looked at:

#=== ERROR while compiling carton.1.0.0 =======================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0 | pinned(https://github.com/robur-coop/carton/releases/download/1.0.0/carton-1.0.0.tbz)
# path                 ~/.opam/5.3/.opam-switch/build/carton.1.0.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p carton -j 71
# exit-code            1
# env-file             ~/.opam/log/carton-7-93c58d.env
# output-file          ~/.opam/log/carton-7-93c58d.out
### output ###
# File "test/carton-lwt/dune", line 5, characters 43-53:
# 5 |  (libraries logs.fmt digestif alcotest-lwt carton-lwt))
#                                                ^^^^^^^^^^
# Error: Library "carton-lwt" not found.
# -> required by _build/default/test/carton-lwt/test.exe
# -> required by alias test/carton-lwt/runtest in test/carton-lwt/dune:2

CHANGES:

- New version of Carton
@dinosaure dinosaure force-pushed the release-carton-1.0.0 branch from b9ffc5a to 75bcaa0 Compare January 21, 2025 10:46
@mseri
Copy link
Member

mseri commented Jan 22, 2025

almost ready, there are still some lowerbound issues with the -miou version on ocaml >= 5:


#=== ERROR while compiling carton-miou-unix.1.0.0 =============================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0 | pinned(https://github.com/robur-coop/carton/releases/download/1.0.0/carton-1.0.0.tbz)
# path                 ~/.opam/5.3/.opam-switch/build/carton-miou-unix.1.0.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p carton-miou-unix -j 255
# exit-code            1
# env-file             ~/.opam/log/carton-miou-unix-7-42caba.env
# output-file          ~/.opam/log/carton-miou-unix-7-42caba.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -g -bin-annot -I bin/.pack.eobjs/byte -I /home/opam/.opam/5.3/lib/astring -I /home/opam/.opam/5.3/lib/bigarray-compat -I /home/opam/.opam/5.3/lib/cachet -I /home/opam/.opam/5.3/lib/carton -I /home/opam/.opam/5.3/lib/carton/cartonnage -I /home/opam/.opam/5.3/lib/carton/classeur -I /home/opam/.opam/5.3/lib/checkseum/c -I /home/opam/.opam/5.3/lib/cmdliner -I /home/opam/.opam/5.3/lib/decompress/de -I /home/opam/.opam/5.3/lib/decompress/zl -I /home/opam/.opam/5.3/lib/digestif/c -I /home/opam/.opam/5.3/lib/duff -I /home/opam/.opam/5.3/lib/eqaf -I /home/opam/.opam/5.3/lib/fmt -I /home/opam/.opam/5.3/lib/fpath -I /home/opam/.opam/5.3/lib/hxd/core -I /home/opam/.opam/5.3/lib/hxd/string -I /home/opam/.opam/5.3/lib/logs -I /home/opam/.opam/5.3/lib/miou -I /home/opam/.opam/5.3/lib/miou/backoff -I /home/opam/.opam/5.3/lib/miou/sync -I /home/opam/.opam/5.3/lib/miou/unix -I /home/opam/.opam/5.3/lib/mtime -I /home/opam/.opam/5.3/lib/mtime/clock/os -I /home/opam/.opam/5.3/lib/ocaml/threads -I /home/opam/.opam/5.3/lib/ocaml/unix -I /home/opam/.opam/5.3/lib/ohex -I /home/opam/.opam/5.3/lib/optint -I /home/opam/.opam/5.3/lib/progress -I /home/opam/.opam/5.3/lib/progress/engine -I /home/opam/.opam/5.3/lib/stdlib-shims -I /home/opam/.opam/5.3/lib/terminal -I /home/opam/.opam/5.3/lib/terminal/ansi -I /home/opam/.opam/5.3/lib/uucp -I /home/opam/.opam/5.3/lib/uutf -I /home/opam/.opam/5.3/lib/vector -I src/carton-miou-unix/.carton_miou_unix.objs/byte -no-alias-deps -open Dune__exe -o bin/.pack.eobjs/byte/dune__exe__Get.cmo -c -impl bin/get.ml)
# File "bin/get.ml", line 104, characters 48-55:
# 104 |         Logs.debug (fun m -> m "Try to find %a" Ohex.pp (uid :> string));
#                                                       ^^^^^^^
# Error: The value "Ohex.pp" has type
#          "?row_numbers:bool ->
#          ?chars:bool -> unit -> Format.formatter -> string -> unit"
#        but an expression was expected of type "Format.formatter -> 'a -> unit"
#        The first argument is labeled "?row_numbers",
#        but an unlabeled argument was expected

@mseri
Copy link
Member

mseri commented Jan 23, 2025

Thanks a lot!

@mseri mseri merged commit 9c115ea into ocaml:master Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants