Mark all non-latest opam-* pre-releases as deprecated #27228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
opam-deprecate-pre-releases
branch
from
76a402a to
ec426d8
Compare
kit-ty-kate
changed the title
avsm
reviewed
Jan 11, 2025
| @@ -46,5 +46,4 @@ url { | |||
| "sha512=b7899244ab620213f2997409c9d8ac63e1a7ba99ff36abdd0acf41ae545ca7e0534e5e2f6c01a9700c10abf2df4f07944cc64fb5dd315a566f6c5b6b19464729" | |||
| ] | |||
| } | |||
| available: opam-version >= "2.1.0" | |||
| flags: avoid-version | |||
| flags: deprecated | |||
There was a problem hiding this comment.
Won't this break opam 2.1 users if we remove the opam-version constraint as well?
There was a problem hiding this comment.
unknown flags are ignored so on opam 2.0 and 2.1 these packages will just not have any special behaviour.
In practice it shouldn't matter anymore as more recent versions are available. It was critical to have it at the time of release because it would've been the latest version and be picked up automatically by the solver, but this is not the case anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in ocaml/opam#6348
Although i'm not sure adding
flags: deprecatedis the best way to do this but we can talk about it later