Jane Street packages v0.16.0 #23742
Jane Street packages v0.16.0 #23742
Conversation
([String.Table.find_or_add] removed in favor of [Hashtbl.find_or_add])
[Time_unix.Span] removed in favor of [Time_float_unix.Span]
Must specify [~how:Async_kernel.Monad_Sequence.how]
Yojson-converters for primitive types need to be explicitly brought into scope
[Caml] deprecated in favor of [Stdlib]
Must specify [~how:Async_kernel.Monad_Sequence.how]
[Sequence.Step.t] variant type now uses inlined records
Sexp converters for primitive types need to be explicitly brought into scope
This reverts commit 4a740ad.
Yojson-converters for primitive types need to be explicitly brought into scope
[X.Set.fold] removed in favor of [Set.fold]
Must specify [~how:Async_kernel.Monad_Sequence.how]
Yojson-converters for primitive types need to be explicitly brought into scope
Yojson-converters for primitive types need to be explicitly brought into scope
Yojson-converters for primitive types need to be explicitly brought into scope
Yojson-converters for primitive types need to be explicitly brought into scope
Yojson-converters for primitive types need to be explicitly brought into scope
[ident] removed in favor of [Fn.id]
[ident] removed in favor of [Fn.id]
[Caml] deprecated in favor of [Stdlib]
[String.Map.set] removed in favor of [Map.set]
Must specify [~how:Async_kernel.Monad_Sequence.how]
[Caml] deprecated in favor of [Stdlib]
[Caml] deprecated in favor of [Stdlib]
| @@ -0,0 +1,38 @@ | |||
| opam-version: "2.0" | |||
There was a problem hiding this comment.
@LaurentMazare Hi sorry to bother you. Could you confirm ocaml-torch is changing maintainer? I'm not seeing any mentioned of this change in the original repository https://github.com/LaurentMazare/ocaml-torch but janestreet maintainers told me the change was agreed.
There was a problem hiding this comment.
@kit-ty-kate thanks for checking. Indeed this change was agreed and I can confirm that Jane Street will maintain the ocaml-torch package going forward, I'll tweak the readme of my repo to make this explicit.
|
I'm closing this PR temporarily until the issues with it crashing the CI are resolved, as it's blocking all the others being tested. Will re-open as soon as that is sorted. It is easier if these PRs come in as smaller chunks (e.g a new release of Base and its dependents, followed by Core, followed by everything else) |
|
This can be re-opened when you're ready @dkalinichenko-js @avsm |
|
Reopening as requested. Let's see 🤞 |
|
If this crashes again can we wait until #23814 is merged? |
|
Sure, in theory the issue that broke the CI last time should be resolved now. But if there are issues we will promptly close it. |
|
I'm closing this again while #23814 is also completely hosing the cluster. And @dkalinichenko-js might, I please get a view on my request earlier about getting this PR broken up into stages, as we used to do in earlier releases?
It's far easier to review and merge if we add upper bounds first for Base, and then add Core, and then the remaining libraries. |
Hi! I opened #23834 for the latest release of Base (and Sexplib0). It seems even draft PRs trigger the CI, so I'm going to avoid creating a PR for Core & dependencies for now. The branch for Core is located at https://github.com/janestreet/main-opam-repository/tree/janestreet-v0.16-core. |
This PR adds Jane Street packages v0.16.0.