Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctypes 0.20.2 #23357

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Add ctypes 0.20.2 #23357

merged 1 commit into from
Mar 21, 2023

Conversation

yallop
Copy link
Member

@yallop yallop commented Feb 18, 2023

No description provided.

@mseri
Copy link
Member

mseri commented Mar 2, 2023

There is a segmentation fault on macos/arm64:

#=== ERROR while compiling ctypes.0.20.2 ======================================#
# context              2.1.4 | macos/arm64 | ocaml-base-compiler.5.0.0 | pinned(https://github.com/ocamllabs/ocaml-ctypes/archive/0.20.2.tar.gz)
# path                 ~/.opam/5.0.0/.opam-switch/build/ctypes.0.20.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build make test
# exit-code            2
# env-file             ~/.opam/log/ctypes-69717-356276.env
# output-file          ~/.opam/log/ctypes-69717-356276.out
### output ###
[...]
# OK
# running test-complex
# ...
# Ran: 3 tests in: 0.00 seconds.
# OK
# running test-bools
# ..
# Ran: 2 tests in: 0.00 seconds.
# OK
# running test-callback_lifetime
# ../bin/sh: line 1: 79339 Segmentation fault: 11  CAML_LD_LIBRARY_PATH=. LD_LIBRARY_PATH=clib DYLD_LIBRARY_PATH=clib ./test-callback_lifetime.native -runner sequential
# make: *** [run-test-callback_lifetime] Error 139

In both ocaml 5.0.0 and ocaml 4.14.1 CI

@mseri
Copy link
Member

mseri commented Mar 2, 2023

The other interesting failure is

#=== ERROR while compiling tezos-baking-alpha.15.1 ============================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/tezos-baking-alpha.15.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p tezos-baking-alpha -j 31
# exit-code            1
# env-file             ~/.opam/log/tezos-baking-alpha-7-6613de.env
# output-file          ~/.opam/log/tezos-baking-alpha-7-6613de.out
### output ###
# File "src/proto_alpha/lib_delegate/test/dune", line 29, characters 0-87:
# 29 | (rule
# 30 |  (alias runtest)
# 31 |  (package tezos-baking-alpha)
# 32 |  (action (run %{dep:./main.exe})))
# (cd _build/default/src/proto_alpha/lib_delegate/test && ./main.exe)
# Testing `protocol_alpha'.
# This run has ID `KA5I2ZXD'.
# 
#   [OK]          scenario          0   reaches level 5.
#   [OK]          scenario          1   scenario t1.
#   [OK]          scenario          2   scenario t2.
#   [OK]          scenario          3   scenario t3.
#   [OK]          scenario          4   scenario f2.
#   [OK]          scenario          5   scenario m1.
#   [OK]          scenario          6   scenario m2.
#   [OK]          scenario          7   scenario m3.
#   [OK]          scenario          8   scenario m4.
#   [OK]          scenario          9   scenario m5.
#   [OK]          scenario         10   scenario m6.
# > [FAIL]        scenario         11   scenario m7.
#   [OK]          scenario         12   scenario m8.
# 
# ┌──────────────────────────────────────────────────────────────────────────────┐
# │ [FAIL]        scenario         11   scenario m7.                             │
# └──────────────────────────────────────────────────────────────────────────────┘
# Checking provided seed.
# mockup client uses custom bootstrap accounts:
# name:bootstrap1
# sk_uri:unencrypted:edsk3gUfUPyBSfrS9CCgmCiQsTCHGkviBDusMxDJstFtojtc1zcpsh
# amount:4000000;
# name:bootstrap2
# sk_uri:unencrypted:edsk39qAm1fiMjgmPkw1EgQYkMzkJezLNewd7PLNHTkr6w9XA2zdfo
# amount:4000000;
# name:bootstrap3
# sk_uri:unencrypted:edsk4ArLQgBTLWG5FJmnGnT689VKoqhXwmDPBuGx3z4cvwU9MmrPZZ
# amount:4000000;
# name:bootstrap4
# sk_uri:unencrypted:edsk2uqQB9AY4FvioK2YMdfmyMrer5R8mGFyuaLLFfSRo8EoyNdht3
# amount:4000000
# 
# Error:
#   the test is taking longer than 60 seconds
#   
# 
# [exception] Alcotest_engine__Core.Make(P)(M).Test_error
#             Raised at Json_encoding.Make.destruct_obj.assoc in file "src/json_encoding.ml", line 499, characters 14-29
#             Called from Json_encoding.Make.destruct_obj.(fun) in file "src/json_encoding.ml", line 527, characters 26-43
#             
# Logs saved to `~/.opam/4.14/.opam-switch/build/tezos-baking-alpha.15.1/_build/default/src/proto_alpha/lib_delegate/test/_build/_tests/protocol_alpha/scenario.011.output'.
#  ──────────────────────────────────────────────────────────────────────────────
# 
# Full test results in `~/.opam/4.14/.opam-switch/build/tezos-baking-alpha.15.1/_build/default/src/proto_alpha/lib_delegate/test/_build/_tests/protocol_alpha'.
# 1 failure! in 192.842s. 13 tests run.

but this could be unrelated

@kit-ty-kate
Copy link
Member

macOS/arm64 wasn't tested during the last release so this probably isn't a new problem. Let's merge for now and I've opened yallop/ocaml-ctypes#730 in hope to have that fixed for next time

@kit-ty-kate kit-ty-kate merged commit 74a4b72 into ocaml:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants