-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Dune version to 3.8 #7051
chore: bump Dune version to 3.8 #7051
Conversation
25bf864
to
6680d95
Compare
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 114ad1ce-bea9-4f82-a0f2-f70abcc9c58f -->
6680d95
to
312b65b
Compare
Signed-off-by: Ali Caglayan <[email protected]>
I just tried bumping dune version on my personal project to 3.8 and got this error:
My Should this be reverted? |
No, you should install Dune 3.8. |
Latest release is 3.7.1 https://ocaml.org/p/dune/latest |
I don't understand what you're asking. |
I'm saying that until dune 3.8 is available to the general public from opam repository, it should not be the |
Alternatively, the docs could take advantage of ReadTheDocs' versioning feature to specify version numbers that match with the docs version, e.g. it's fine to mention 3.8 on https://dune.readthedocs.io/en/3.8/ But not on https://dune.readthedocs.io/en/stable/ because that is currently 3.7 |
I think you might be missing the point that it's possible to use the latest version of dune without opam. For example, dune 3.8 is probably already available in the ArchLinux AUR. |
Sure, it's possible in some distros. But the official way to install dune is with opam: https://dune.build/install . That's also how macOS and Windows users will do it. And we don't really want to tell users to install dune with their distro package managers or from unreleased commits to work around errors arising from following the official documentation. Right?
Anyone following this sequence will immediately get a build error. This is an unnecessary UX pitfall. It can be resolved fairly easily by updating the |
In the meantime you can use
This is a transient state due to unusual load on the CI machines; we don't need to change the release process for this. |
This PR was merged in February. Haven't we been in this state since then? |
No. We've been in that state (https://dune.readthedocs.io/ mentions 3.8) since 3.8.0 got released on github, last week. |
Oh I see, so the RTD page is only updated when the release is tagged and done on GH. Thanks for the clarification. |
For more clarification:
|
No description provided.