Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Dune version to 3.8 #7051

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Feb 12, 2023

No description provided.

@Alizter Alizter marked this pull request as draft February 12, 2023 20:50
@Alizter Alizter added this to the 3.8.0 milestone Feb 12, 2023
@Alizter Alizter force-pushed the ps/rr/chore__bump_dune_version_to_3_8 branch from 25bf864 to 6680d95 Compare February 12, 2023 21:47
Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: 114ad1ce-bea9-4f82-a0f2-f70abcc9c58f -->
@Alizter Alizter force-pushed the ps/rr/chore__bump_dune_version_to_3_8 branch from 6680d95 to 312b65b Compare February 13, 2023 00:41
@Alizter Alizter marked this pull request as ready for review February 17, 2023 17:09
@Alizter Alizter requested a review from emillon February 18, 2023 17:26
@rgrinberg rgrinberg merged commit 20a1f10 into ocaml:main Feb 19, 2023
@Alizter Alizter deleted the ps/rr/chore__bump_dune_version_to_3_8 branch February 19, 2023 13:47
moyodiallo pushed a commit to moyodiallo/dune that referenced this pull request Apr 3, 2023
@yawaramin
Copy link
Contributor

yawaramin commented May 28, 2023

I just tried bumping dune version on my personal project to 3.8 and got this error:

$ dune build
File "dune-project", line 1, characters 11-14:
1 | (lang dune 3.8)
               ^^^
Error: Version 3.8 of the dune language is not supported.
Supported versions of this extension in version 3.8 of the dune language:
- 1.0 to 1.12
- 2.0 to 2.9
- 3.0 to 3.7

My dune --version: 3.7.1.

Should this be reverted?

@anmonteiro
Copy link
Collaborator

No, you should install Dune 3.8.

@yawaramin
Copy link
Contributor

Latest release is 3.7.1 https://ocaml.org/p/dune/latest

@anmonteiro
Copy link
Collaborator

I don't understand what you're asking. (lang dune 3.8) is available since version 3.8 of Dune. If you'd like to use it, you need to install that version. It should be available once this is merged: ocaml/opam-repository#23814

@yawaramin
Copy link
Contributor

yawaramin commented May 28, 2023

I'm saying that until dune 3.8 is available to the general public from opam repository, it should not be the lang version mentioned in the docs. Because when people try it out right now, they will immediately get an error because the latest version they will have is 3.7.1.

@yawaramin
Copy link
Contributor

yawaramin commented May 28, 2023

Alternatively, the docs could take advantage of ReadTheDocs' versioning feature to specify version numbers that match with the docs version, e.g. it's fine to mention 3.8 on https://dune.readthedocs.io/en/3.8/

But not on https://dune.readthedocs.io/en/stable/ because that is currently 3.7

@rgrinberg
Copy link
Member

I think you might be missing the point that it's possible to use the latest version of dune without opam. For example, dune 3.8 is probably already available in the ArchLinux AUR.

@yawaramin
Copy link
Contributor

yawaramin commented May 28, 2023

Sure, it's possible in some distros. But the official way to install dune is with opam: https://dune.build/install . That's also how macOS and Windows users will do it. And we don't really want to tell users to install dune with their distro package managers or from unreleased commits to work around errors arising from following the official documentation. Right?

  • We have the opam install dune command on the landing page which installs 3.7.1 now
  • We have (lang dune 3.8) in the docs (since February)

Anyone following this sequence will immediately get a build error. This is an unnecessary UX pitfall. It can be resolved fairly easily by updating the (lang dune VERSION) in the docs after the opam repository merge.

@emillon
Copy link
Collaborator

emillon commented May 30, 2023

In the meantime you can use

opam pin add dune.3.8.0 https://github.com/ocaml/dune/releases/download/3.8.0/dune-3.8.0.tbz

This is a transient state due to unusual load on the CI machines; we don't need to change the release process for this.

@yawaramin
Copy link
Contributor

This PR was merged in February. Haven't we been in this state since then?

@emillon
Copy link
Collaborator

emillon commented May 30, 2023

No. We've been in that state (https://dune.readthedocs.io/ mentions 3.8) since 3.8.0 got released on github, last week.

@yawaramin
Copy link
Contributor

Oh I see, so the RTD page is only updated when the release is tagged and done on GH. Thanks for the clarification.

@anmonteiro
Copy link
Collaborator

Oh I see, so the RTD page is only updated when the release is tagged and done on GH. Thanks for the clarification.

For more clarification:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants