refactor(pkg): unrefutable constraints #11453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce loading of unnecessary opam packages by making sure that every local package must not conflict with the constraints of local packages. Such packages can never be used for a solution, and loading them is pointless. This is a large speed improvement for repos that write many constraints (such as bonsai for example). <!-- ps-id: cf770d91-1c12-43a4-aae7-2e721575acc7 --> Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
commented
Feb 6, 2025
| ~stats_updater | ||
| ~constraints) | ||
| and local_packages' = | ||
| lazy |
There was a problem hiding this comment.
All of this "laziness" is just to allow the mutually recursive definition of Context.t and the local packages which require the context to evaluate their constraints.
rgrinberg
changed the title
gridbugs
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce loading of unnecessary opam packages by making sure that every local package must not conflict with the constraints of local packages. Such packages can never be used for a solution, and loading them is pointless.
This is a large speed improvement for repos that write many constraints (such as bonsai for example).