fix: package management working with ocaml.5.3.0 #11310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
requested changes
Jan 16, 2025
|
There's no need to log changes to components that are advertised as experimental |
Unrelated changes should be moved to separate PR's |
maiste
force-pushed
the
fix/ocaml-5.3.0
branch
from
4676a05 to
7633f6b
Compare
Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
Leonidas-from-XIV
force-pushed
the
fix/ocaml-5.3.0
branch
from
7633f6b to
c0f9083
Compare
Leonidas-from-XIV
approved these changes
Jan 17, 2025
maiste
added a commit
to maiste/dune
that referenced
this pull request
Jan 20, 2025
* fix: allow ocaml.5.3.0 to be built with package management Signed-off-by: Etienne Marais <[email protected]> * fix: apply reviews Signed-off-by: Etienne Marais <[email protected]> --------- Signed-off-by: Etienne Marais <[email protected]>
maiste
added a commit
that referenced
this pull request
Jan 20, 2025
…1365) Signed-off-by: Etienne Marais <[email protected]>
ElectreAAS
pushed a commit
to ElectreAAS/dune
that referenced
this pull request
Jan 27, 2025
* fix: allow ocaml.5.3.0 to be built with package management Signed-off-by: Etienne Marais <[email protected]> * fix: apply reviews Signed-off-by: Etienne Marais <[email protected]> --------- Signed-off-by: Etienne Marais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of
ocaml.5.3.0introduces a new transitive dependency for the compiler:ocaml->ocaml-base-compiler->ocaml-compiler. Consequently the solution is to markocaml-compileras a toolchain element and compute the transitive dependencies to be able to fetch the binaries before installing. It also creates a newconfig.statusfile to make the target understand the compiler is already installed (file required by5.3.0).Fixes #11309 (with the deep help of @Leonidas-from-XIV and @art-w)
(Take the opportunity to remove the unused
ocamlfunction at the same time).This PR will require to release a new version of Dune to make package management work with it.
@rgrinberg should we start to log this kind of changes in a lock file, it would be important for this release. WDTY?