-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate maintenance_intent #11308
Validate maintenance_intent #11308
Conversation
a78c24d
to
e491be8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the extensive suite of tests and that it properly validates the fairly elaborate language in the intents.
Can you add another changelog entry for this?
eabb151
to
4a0eb43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc @rgrinberg I believe this should be a good follow-up to finish up the loose ends from #11274
Signed-off-by: ArthurW <[email protected]>
Signed-off-by: ArthurW <[email protected]>
4a0eb43
to
cf84742
Compare
* Validate maintenance_intent Signed-off-by: ArthurW <[email protected]> * Fix after review Signed-off-by: ArthurW <[email protected]> --------- Signed-off-by: ArthurW <[email protected]>
Follow-up on #11274 to check the opam maintenance intent format and report any error. The syntax is described in the opam archiving process.