Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate maintenance_intent #11308

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

art-w
Copy link
Contributor

@art-w art-w commented Jan 16, 2025

Follow-up on #11274 to check the opam maintenance intent format and report any error. The syntax is described in the opam archiving process.

@art-w art-w force-pushed the validate-maintenance-intent branch from a78c24d to e491be8 Compare January 16, 2025 10:56
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the extensive suite of tests and that it properly validates the fairly elaborate language in the intents.

Can you add another changelog entry for this?

src/dune_lang/package_info.ml Show resolved Hide resolved
test/blackbox-tests/test-cases/opam-maintenance-intent.t Outdated Show resolved Hide resolved
src/dune_lang/package_info.ml Outdated Show resolved Hide resolved
src/dune_lang/package_info.ml Outdated Show resolved Hide resolved
src/dune_lang/package_info.ml Outdated Show resolved Hide resolved
src/dune_lang/package_info.ml Show resolved Hide resolved
src/dune_lang/package_info.ml Outdated Show resolved Hide resolved
@art-w art-w force-pushed the validate-maintenance-intent branch from eabb151 to 4a0eb43 Compare January 16, 2025 16:20
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @rgrinberg I believe this should be a good follow-up to finish up the loose ends from #11274

@Leonidas-from-XIV Leonidas-from-XIV force-pushed the validate-maintenance-intent branch from 4a0eb43 to cf84742 Compare January 17, 2025 10:52
@Leonidas-from-XIV Leonidas-from-XIV merged commit 3f64250 into ocaml:main Jan 17, 2025
27 checks passed
ElectreAAS pushed a commit to ElectreAAS/dune that referenced this pull request Jan 27, 2025
* Validate maintenance_intent

Signed-off-by: ArthurW <[email protected]>

* Fix after review

Signed-off-by: ArthurW <[email protected]>

---------

Signed-off-by: ArthurW <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants