Wasm_of_ocaml: fix the execution of tests in a sandbox #11304
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
wasm-sandboxing
branch
2 times, most recently
from
cafa3fb to
3168dc3
Compare
Signed-off-by: Jérôme Vouillon <[email protected]>
vouillon
force-pushed
the
wasm-sandboxing
branch
from
3168dc3 to
05fa8c7
Compare
…andbox Signed-off-by: Jérôme Vouillon <[email protected]>
…dbox Signed-off-by: Jérôme Vouillon <[email protected]>
vouillon
changed the title
hhugo
approved these changes
Jan 16, 2025
|
@rgrinberg, could this be including in a 3.17.* minor release ? |
rgrinberg
reviewed
Jan 16, 2025
| | `js Wasm -> | ||
| Bindings.Unnamed | ||
| (Dep_conf.File | ||
| (String_with_vars.make_text loc (s ^ Js_of_ocaml.Ext.wasm_dir))) |
There was a problem hiding this comment.
Is this tested at all? This should be accessible via %{deps} in some fields now I imagine.
There was a problem hiding this comment.
I have added a test that does not pass without this change. Is it enough?
Best to ask one of the release managers. @maiste or @Leonidas-from-XIV? |
|
Thanks, @rgrinberg for pinging (and the promotion 😉) |
rgrinberg
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wasm code is included in a separate
.bc.wasm.assetsdirectory that needs to be copied in the sandbox as well.