pkg: add argument to pkg lock to print perf stats #11263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
force-pushed
the
pkg-lock-perf-stats
branch
from
38caebb to
786d112
Compare
maiste
approved these changes
Jan 9, 2025
| ;; | ||
|
|
||
| let term = | ||
| let+ builder = Common.Builder.term | ||
| and+ version_preference = Version_preference.term | ||
| and+ lock_dirs_arg = Pkg_common.Lock_dirs_arg.term in | ||
| and+ lock_dirs_arg = Pkg_common.Lock_dirs_arg.term | ||
| and+ print_perf_stats = Arg.(value & flag & info [ "print-perf-stats" ]) in |
There was a problem hiding this comment.
Do we want to generalize perf improvement to Dune or just to package management? Otherwise, it can be nice to move it to Common.
There was a problem hiding this comment.
IMHO I think for now it's perfectly fine to just improve the locking performance as it is the biggest bottleneck.
Leonidas-from-XIV
approved these changes
Jan 9, 2025
Signed-off-by: Stephen Sherratt <[email protected]>
maiste
force-pushed
the
pkg-lock-perf-stats
branch
from
786d112 to
2054ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing performance work on the solver it's helpful to see a breakdown of the time spent running the solver vs the time spent updating the package repos. I've also found the number of expanded packages to be both much higher than I expected and highly correlated to the performance runtime (unsurprisingly) so it's included in the stats too.