test: exhibit a bug when promoting directories #11213
Conversation
| @@ -0,0 +1,43 @@ | |||
| Tests for promoting directory targets | |||
There was a problem hiding this comment.
Generally we try to avoid cram test folders with multiple files. Can you rename this file into deep-subdir.t and inline the dune and dune-project?
Otherwise the test looks good to me!
There was a problem hiding this comment.
Thanks! And sorry for the delay: I missed the notification...
I now see that @ElectreAAS has incorporated this PR into #11226, with your suggestion and along with a fix (thanks a lot!). Should I close this one then?
There was a problem hiding this comment.
As you want, I incorporated your test because I wanted to be sure I wasn't making any existing bug worse, but that doesn't mean you have to close this PR
If you can apply Marek's suggestion we can merge this and I'll modify #11226 accordingly
There was a problem hiding this comment.
Done. (And signed the commits.)
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
panglesd
force-pushed
the
promote-dir-bug
branch
from
f8bb15b to
87c7fb1
Compare
There was a problem hiding this comment.
The tests needs to be made reproducible but otherwise looks good :-)
P.S.: Yes, I agree with @ElectreAAS. It's generally nice to merge repro cases first to show that PR that fixes it solves the issue.
|
|
||
| $ dune build deep_copied --verbose | ||
| Shared cache: enabled-except-user-rules | ||
| Shared cache location: /home/panglesd/.cache/dune/db |
There was a problem hiding this comment.
Would the non --verbose run be enough? Otherwise you need to figure out paths and things that might change.
This shows a reproduction for issue #11214!