test: reproduce @ocaml-index failing with package management
#10986
Conversation
Signed-off-by: Andrew Patterson <[email protected]>
| being in its own directory. | ||
|
|
||
| This can't be just written to disk, I /think/ so it cat get an absolute path | ||
| in the source stanza. |
There was a problem hiding this comment.
I don't understand this paragraph.
There was a problem hiding this comment.
That paragraph only applies to the next command. Originally, I just had the build command in the test case, which didn't work, so I moved building the package file back to here.
The only real change between this file and pkg/libraries.t is the build command. Signed-off-by: Andrew Patterson <[email protected]>
|
I've updated the pr to put the issue in a single cram file. |
| > EOF | ||
|
|
||
| $ cat >dune <<EOF | ||
| > (dirs (:standard \ external_sources)) |
There was a problem hiding this comment.
You can probably avoid this by putting external_sources in one folder, the repo that uses it in another and that refer to it via (copy $PWD/../external_sources).
There was a problem hiding this comment.
Right now, this file is the same as test/blackbox-tests/test-cases/pkg/libraries.t, just with a slightly different comment and building the index instead of foo.cma. I literally started by copying over that file. I can definitely still make this change, it just seems weird to change this from the directly analogous working test.
(If I don't change it, maybe it's worth noting this in the file, instead of just in the commit description?)
There was a problem hiding this comment.
I just made this change. If this really matters, I can also send a separate pull request to update pkg/libraries.t.
Signed-off-by: Andrew Patterson <[email protected]>
|
Merged in #10986. Thanks |
reproduces the build failure in #10985