Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging #548

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix packaging #548

merged 3 commits into from
Jan 6, 2025

Conversation

NathanReb
Copy link
Collaborator

I ran into some errors while testing out the repo before attempting the release, this should fix those:

  1. Correctly allocate tests to their respective packages. Our main test suite now is affected to ppxlib so they aren't run when running something like dune build -p ppxlib-tools or opam install -t ppxlib-tools. This prevent some test dependencies to leak from ppxlib to ppxlib-tools.
  2. Bump our dune lang version. Initially opam CI reported that we had to update dune lang to 2.9 but while solving 1, I actually ended up having to bump it to 3.8. This enabled some warnings that I guess where not part of the default build profile before and I ended up fixing those as well.

@NathanReb NathanReb added the no changelog Use this label to disable the changelog check github action label Dec 19, 2024
@NathanReb
Copy link
Collaborator Author

It seems we can't currently allocate cinaps stanzas to specific packages so I ended up also adding a test deps on cinaps in ppxlib-tools for now. I reported this upstream: ocaml/dune#11232.

If there's a better, easier fix, I'll of course patch this before the release!

Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
@NathanReb
Copy link
Collaborator Author

Not sure I understand what's wrong with the bench build, are you any more familiar with it than I am @patricoferris ?

@NathanReb
Copy link
Collaborator Author

Ok the question rather was how did it even work before but I fixed it. It needed an explicitly declared dependency on the drivers/ folder. I guess bumping the dune lang changed dune's behaviour and it stopped copying those files to _build directory without any explicit dependency over them.

Copy link
Collaborator

@patricoferris patricoferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NathanReb -- sorry for only getting around to this now, post holidays. This seems like a good clean-up to me

@NathanReb
Copy link
Collaborator Author

No worries @patricoferris ! I was on holidays myself as well!

@NathanReb NathanReb merged commit beee953 into ocaml-ppx:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Use this label to disable the changelog check github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants