-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lin Domain.DLS test #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little test!
As keys cannot be freed and as new_key
is really only called from init
, it might make sense to use a constant key? 🤔 Or allocate a list of keys initially and pick one of them in init
?
I grew increasingly unhappy with the short-comings the initial version, and therefore set out to write an The resulting
I also adjusted the This results in a negative test, that is quickly able to produce a counterexample where simultanious changes in two children are not seen in the sibling:
|
ae5ad69
to
dd95793
Compare
A round of focused tests confirmed that the I expect this full CI run to fail its |
CI summary
Out of 59 workflows and 19 failures, the 2 non- |
This PR adds a quick Lin stress test of
Domain.DLS
.It uses only one
DLS.key
for a start - not impressive but it is a start.We might revisit it based on
multiple-ts
or consider replacing it by anSTM
test later.Without the optional
~split_from_parent
the child domain does not inherit the key, which makes for a fast negative test.I did notice that the test takes longer and longer as it progresses, which may be due to the inability to remove
DSL.key
s again. For this reason, it seems faster to run the negative test first...We might consider (a) running the property/test in child domain or (b) splitting the two tests to run in separate processes.