Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notion of difference, useful for diffing queries #2

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 31, 2019

Hopefully this eventually grows into supporting lattice (and related algebra) operations more fully.

Hopefully this eventually grows into supporting lattice (and related
algebra) operations more fully.
@kmicklas
Copy link
Collaborator

This can already be built with mapMaybeV and a monoid operation, and I don't think it's any more efficient, so I'd prefer it as a separate function outside the View class.

@Ericson2314
Copy link
Member Author

I'm not sure that's just as efficient. Beyond the intermediate datastructure, there's the fact that the function has to be run on every value in the new one. Difference only runs the function on elements in both; it can skip subtrees if it can tell they are not in the subtracted vessel. Not sure if the map data structures currently exploit this, but not describe ones (internal maps, etc) could probably do even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants