Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring some topics to use VALUE_SUBJECT_STRATEGY #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/main/java/kafdrop/config/MessageFormatConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,26 @@ public void setFormat(MessageFormat format) {
this.format = format;
}
}

@Component
@ConfigurationProperties(prefix = "key")
public static final class KeyFormatProperties {
private MessageFormat format;

@PostConstruct
public void init() {
// Set a default message format if not configured.
if (format == null) {
format = MessageFormat.DEFAULT;
}
}

public MessageFormat getFormat() {
return format;
}

public void setFormat(MessageFormat format) {
this.format = format;
}
}
}
11 changes: 6 additions & 5 deletions src/main/java/kafdrop/controller/MessageController.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import javax.validation.constraints.Min;
import javax.validation.constraints.NotNull;

import kafdrop.config.MessageFormatConfiguration;
import kafdrop.util.*;
import org.springframework.http.MediaType;
import org.springframework.stereotype.Controller;
Expand Down Expand Up @@ -62,19 +63,19 @@ public final class MessageController {
private final MessageInspector messageInspector;

private final MessageFormatProperties messageFormatProperties;
private final MessageFormatProperties keyFormatProperties;
private final MessageFormatConfiguration.KeyFormatProperties keyFormatProperties;

private final SchemaRegistryProperties schemaRegistryProperties;

private final ProtobufDescriptorProperties protobufProperties;

public MessageController(KafkaMonitor kafkaMonitor, MessageInspector messageInspector, MessageFormatProperties messageFormatProperties, MessageFormatProperties keyFormatProperties, SchemaRegistryProperties schemaRegistryProperties, ProtobufDescriptorProperties protobufProperties) {
public MessageController(KafkaMonitor kafkaMonitor, MessageInspector messageInspector, MessageFormatProperties messageFormatProperties, MessageFormatConfiguration.KeyFormatProperties keyFormatProperties, SchemaRegistryProperties schemaRegistryProperties, ProtobufDescriptorProperties protobufProperties) {
this.kafkaMonitor = kafkaMonitor;
this.messageInspector = messageInspector;
this.messageFormatProperties = messageFormatProperties;
this.keyFormatProperties = keyFormatProperties;
this.schemaRegistryProperties = schemaRegistryProperties;
this.protobufProperties = protobufProperties;
this.protobufProperties = protobufProperties;
}

/**
Expand Down Expand Up @@ -312,9 +313,9 @@ public static class PartitionOffsetInfo {
private MessageFormat format;

private MessageFormat keyFormat;

private String descFile;

private String msgTypeName;

public PartitionOffsetInfo(int partition, long offset, long count, MessageFormat format) {
Expand Down
23 changes: 21 additions & 2 deletions src/main/java/kafdrop/util/AvroMessageDeserializer.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import java.nio.*;
import java.util.*;
import java.util.stream.Collectors;


public final class AvroMessageDeserializer implements MessageDeserializer {
Expand All @@ -12,7 +13,7 @@ public final class AvroMessageDeserializer implements MessageDeserializer {

public AvroMessageDeserializer(String topicName, String schemaRegistryUrl, String schemaRegistryAuth) {
this.topicName = topicName;
this.deserializer = getDeserializer(schemaRegistryUrl, schemaRegistryAuth);
this.deserializer = getDeserializer(schemaRegistryUrl, schemaRegistryAuth, topicName);
}

@Override
Expand All @@ -22,15 +23,33 @@ public String deserializeMessage(ByteBuffer buffer) {
return deserializer.deserialize(topicName, bytes).toString();
}

private static KafkaAvroDeserializer getDeserializer(String schemaRegistryUrl, String schemaRegistryAuth) {
private static KafkaAvroDeserializer getDeserializer(String schemaRegistryUrl, String schemaRegistryAuth, String topicName) {
final var config = new HashMap<String, Object>();
config.put(AbstractKafkaSchemaSerDeConfig.SCHEMA_REGISTRY_URL_CONFIG, schemaRegistryUrl);
if (schemaRegistryAuth != null) {
config.put(AbstractKafkaSchemaSerDeConfig.BASIC_AUTH_CREDENTIALS_SOURCE, "USER_INFO");
config.put(AbstractKafkaSchemaSerDeConfig.USER_INFO_CONFIG, schemaRegistryAuth);
}
setConfigFromEnvIfAvailable(topicName, AbstractKafkaAvroSerDeConfig.VALUE_SUBJECT_NAME_STRATEGY, config);
final var kafkaAvroDeserializer = new KafkaAvroDeserializer();
kafkaAvroDeserializer.configure(config, false);
return kafkaAvroDeserializer;
}

private static void setConfigFromEnvIfAvailable(String topicName, String configPath, Map<String,Object> config){
String configPrefix = "SCHEMA_REGISTRY";
String topicScopedEnvPath = Arrays.stream(new String[]{configPrefix, configPath.replaceAll("\\.", "_"), topicName.replaceAll("-", "_") } )
.map(String::toUpperCase).collect(Collectors.joining("_"));

String noTopicScopedEnvPath = Arrays.stream(new String[]{ configPrefix, configPath.replaceAll("\\.", "_") })
.map(String::toUpperCase).collect(Collectors.joining("_"));

for(String envPath : new String[]{topicScopedEnvPath, noTopicScopedEnvPath}) {

String namingStrategyValue = System.getenv(envPath);
if (namingStrategyValue != null) {
config.put(configPath, namingStrategyValue);
}
}
}
}