Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering a disabled state of the input field #54

Merged

Conversation

SjaakSchilperoort
Copy link
Member

@SjaakSchilperoort SjaakSchilperoort commented Aug 13, 2024

Needed for https://github.com/observation/app/issues/478

@SjaakSchilperoort
Copy link
Member Author

SjaakSchilperoort commented Aug 13, 2024

@jonathan-waarneming-nl er gebeurt wat geks als ik deze update gebruik in de observation repo. Als ik mijn branch bijwerk met deze versie, dus:

"@observation.org/react-native-components": "observation/react-native-components#feature/add-disabled-state-to-input-field",

in package.json zet, dan krijg ik typing errors op accordion-collapse-react-native:

error TS7016: Could not find a declaration file for module 'accordion-collapse-react-native'.

Met de develop-versie krijg ik dat niet. Maar mijn change verandert daar niets aan. Heb jij enig idee?

EDIT: Gevonden en opgelost. Was een onterechte verwijdering van een ts-ignore in de eslint-upgrade.

@SjaakSchilperoort SjaakSchilperoort force-pushed the feature/add-disabled-state-to-input-field branch from fb9d5ef to ae92cc6 Compare August 13, 2024 12:24
@SjaakSchilperoort SjaakSchilperoort changed the base branch from develop to feature/update-dependencies August 13, 2024 12:24
Copy link
Collaborator

@jonathan-waarneming-nl jonathan-waarneming-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SjaakSchilperoort SjaakSchilperoort force-pushed the feature/add-disabled-state-to-input-field branch from ae92cc6 to cca046f Compare August 14, 2024 11:26
@SjaakSchilperoort SjaakSchilperoort changed the base branch from feature/update-dependencies to develop August 14, 2024 11:26
@SjaakSchilperoort SjaakSchilperoort merged commit df46135 into develop Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants