feat: reuse documents/embeddings for files with the same sha256sum (+fix pgx bug) #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is fine in the Obot setup, as we're using a static flow config for Obot, but if someone is playing with the flow config to test different settings, this may lead to reusing documents from file that were ingested with an old config - we can add checks for that as a follow-up.
Also, I figured that there's a race condition in the pgvector implementation, because appending to the pgx batch queue is not lock protected and I saw some cases, where documents got lost due to this. This is fixed now.
Issue: obot-platform/obot#1803